Last modified: 2012-02-27 08:48:01 UTC
In function addMissingImage( $filename, $fullpath ) line 193 on http://svn.wikimedia.org/viewvc/mediawiki/trunk/phase3/maintenance/rebuildImages.php?view=markup is a call to a function which isn't yet implemented: 192 # @FIXME: create renameFile() 193 $filename = $this->renameFile( $filename ); If renameFile() hasn't been written yet, we really shouldn't be calling it yet. The end result appears to be that, as soon as the script finds one file which fails to match checkTitleEncoding() (for instance, 'example.jpg' on a wiki where that should've been 'Example.jpg') it stops dead in its tracks with: PHP Fatal error: Call to undefined method ImageBuilder::renameFile() in .../phase3/maintenance/rebuildImages.php on line 193 That means any subsequent missing images don't even get looked at. One possible solution would be the bug 27645 proposal of adding 'some commandline option such as "--skip-unreadable" or similar'. A simpler solution would be to simply comment out or remove the call to renameFile() if (as the FIXME indicates) the function simply does not exist. That will mean that 'example.jpg' still doesn't get renamed 'Example.jpg' but at least the search for missing images would not grind to a screeching halt.
renameFile() was in FiveUpgrade.inc, so IAlex broke this in r72726. The fixme comment was added later by someone who didn't realise that the function in question was created in r9758.
In such case I can also say that you broke it in r22580 by removing wfImageDir() which was used by renameFile().
(In reply to comment #2) > In such case I can also say that you broke it in r22580 by removing > wfImageDir() which was used by renameFile(). Touché.
