Last modified: 2012-03-08 10:43:48 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T36689, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 34689 - Add step property to the pages tag
Add step property to the pages tag
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
ProofreadPage (Other open bugs)
unspecified
All All
: Unprioritized enhancement (vote)
: ---
Assigned To: ThomasV
: patch, patch-need-review
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-02-24 14:52 UTC by Tpt
Modified: 2012-03-08 10:43 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Patch (2.06 KB, patch)
2012-02-24 14:52 UTC, Tpt
Details
New patch with include and exclude (5.49 KB, patch)
2012-02-24 21:06 UTC, Tpt
Details
Some security enhancements (5.67 KB, patch)
2012-02-24 21:40 UTC, Tpt
Details

Description Tpt 2012-02-24 14:52:56 UTC
Created attachment 10090 [details]
Patch

Many contributors has demand a step property to the pages tag in order to include, by example, only odd pages. Here is a patch for including this in ProofreadPage.
Comment 1 Tpt 2012-02-24 21:06:33 UTC
Created attachment 10092 [details]
New patch with include and exclude

Here is an other patch with implementation of include and exclude in order to include or not a list of pages.
The syntax is like this : include="2-6,9,10-20" in order to include pages form 2 to 6, page 9 and pages form 10 to 20. It's the same for exclude.
All is backward with the existent : <pages from=1 to=10 exclude=5 step=2 /> will include pages 1, 3, 7 and 9.

All these features only work with multipages books in pdf or djvu.
Comment 2 Tpt 2012-02-24 21:40:26 UTC
Created attachment 10094 [details]
Some security enhancements
Comment 3 Sumana Harihareswara 2012-02-25 14:01:39 UTC
Thanks for the patch, Thomas!  I'm asking Zaran whether he could review this, and I'm marking the patch "need-review" to indicate that it awaits review.
Comment 4 Zaran 2012-03-08 10:42:29 UTC
Patch applied (with minor changes) in r113358.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links