Last modified: 2012-12-18 01:28:11 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T36716, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 34716 - Use ResourceLoader/mw.config for jsReviewNeedsChange
Use ResourceLoader/mw.config for jsReviewNeedsChange
Status: NEW
Product: MediaWiki extensions
Classification: Unclassified
FlaggedRevs (Other open bugs)
unspecified
All All
: Low enhancement (vote)
: ---
Assigned To: Matthias Mullie
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2012-02-25 21:09 UTC by db [inactive,noenotif]
Modified: 2012-12-18 01:28 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description db [inactive,noenotif] 2012-02-25 21:09:45 UTC 
Setting one var in an one script tag into the global scope is not best practice. Please move this var to mw.config. Thanks.
Comment 1 Antoine "hashar" Musso (WMF) 2012-02-25 21:11:49 UTC 
Patch welcome :-D
Comment 2 db [inactive,noenotif] 2012-02-25 21:59:54 UTC 
There are also two places, where two function (onFRChangeExpiryDropdown/onFRChangeExpiryField) are added with a own script tag. Maybe create a new module or move it to the existing modules.

(In reply to comment #1)
> Patch welcome :-D
MakeGlobalVariablesScript hook?
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links