Last modified: 2012-03-09 09:34:33 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T36737, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 34737 - Zoom buttons appear sometimes on the image, sometimes in the toolbar after update to MW 1.19
Zoom buttons appear sometimes on the image, sometimes in the toolbar after up...
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
ProofreadPage (Other open bugs)
unspecified
All All
: High major with 1 vote (vote)
: ---
Assigned To: ThomasV
: patch, patch-need-review
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-02-26 16:41 UTC by Candalua
Modified: 2012-03-09 09:34 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Patch (1.62 KB, patch)
2012-03-02 17:38 UTC, Tpt
Details

Description Candalua 2012-02-26 16:41:12 UTC
The 5 button that control zoom, header/footer display and layout sometimes appear on the left upper corner of the scanned image, and sometimes they appear in the toolbar under "Proofread tools". 

This seems to depend on which module is faster to load: if the toolbar loads first, the PRP extension finds it and puts the buttons there, if the PRP loads first it doesn't find the toolbar and puts the button on the image.

It seems to happen on all wikisource subdomains (I've seen it on it, en, fr).
Comment 1 Tpt 2012-03-02 17:38:47 UTC
Created attachment 10162 [details]
Patch

Here is a patch that solve the problem and optimize an other thing using the new js lib. Can someone review and apply it ?
Comment 2 Zaran 2012-03-09 09:34:33 UTC
Patch applied in r113461.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links