Last modified: 2013-08-11 05:28:25 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T36738, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 34738 - ResourceLoader should have a context instead of using global object variables
ResourceLoader should have a context instead of using global object variables
Status: NEW
Product: MediaWiki
Classification: Unclassified
ResourceLoader (Other open bugs)
unspecified
All All
: Low enhancement (vote)
: Future release
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2012-02-26 16:48 UTC by Alexandre Emsenhuber [IAlex]
Modified: 2013-08-11 05:28 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Alexandre Emsenhuber [IAlex] 2012-02-26 16:48:47 UTC 
Currently, ResourceLoader modules use global object variables such as $wgUser and $wgLang; they should rather get them from a context object (maybe integrated in ResourceLoaderContext?)
Comment 1 Krinkle 2012-03-05 05:58:10 UTC 
Can you be more specific?
Comment 2 Alexandre Emsenhuber [IAlex] 2012-03-05 10:23:06 UTC 
$wgUser is used in ResourceLoaderUserCSSPrefsModule.php, ResourceLoaderUserOptionsModule.php and ResourceLoaderUserTokensModule.php.
$wgLang is used in ResourceLoaderContext.php.
$wgRequest is used in ResourceLoader.php.

These variables should be get from a context object instead (not the ResourceLoader one, but RequestContext or ContextSource).
Comment 3 Mark A. Hershberger 2012-09-28 21:50:15 UTC 
release is imminent.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links