Last modified: 2012-03-08 22:00:32 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T36764, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 34764 - Gerrit puppet linter should only lint operation/puppet not PHP projects.
Gerrit puppet linter should only lint operation/puppet not PHP projects.
Status: RESOLVED FIXED
Product: Wikimedia
Classification: Unclassified
Git/Gerrit (Other open bugs)
unspecified
All All
: Low normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2012-02-27 23:10 UTC by Antoine "hashar" Musso (WMF)
Modified: 2012-03-08 22:00 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Antoine "hashar" Musso (WMF) 2012-02-27 23:10:32 UTC 
In all repository, Gerrit lints the submitted patches using only puppet which can give false positive message. For example, sending an invalid PHP file result in a message saying "Verified Lint check passed." https://gerrit.wikimedia.org/r/#change,2806

The root cause is Gerrit patchset-created hook which is used globally for all repository. Originally created for operations/puppet , we need to update it so it only lint that repository.

See hook in operations/puppet repo in /files/gerrit/hooks/
Comment 1 Antoine "hashar" Musso (WMF) 2012-03-08 22:00:32 UTC 
Fix made by Ryan with https://gerrit.wikimedia.org/r/2992
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links