Last modified: 2012-09-04 19:40:34 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T36787, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 34787 - Sanity check before $wgHooks['UserLoadAfterLoadFromSession'] doesn't validate all the required settings
Sanity check before $wgHooks['UserLoadAfterLoadFromSession'] doesn't validate...
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
LdapAuthentication (Other open bugs)
unspecified
All All
: Low minor (vote)
: ---
Assigned To: Ryan Lane
: patch, patch-need-review
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2012-02-29 01:46 UTC by Damian Z
Modified: 2012-09-04 19:40 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Diff of changes (355 bytes, patch)
2012-02-29 01:46 UTC, Damian Z 		Details
Add an attachment (proposed patch, testcase, etc.)

Description Damian Z 2012-02-29 01:46:49 UTC 
Created attachment 10127 [details]
Diff of changes

The current sanity check which ensures that the wgLDAPAutoAuthUsername variable is set to something doesn't ensure that the wgLDAPAutoAuthDomain is set to something.

If the wgLDAPAutoAuthDomain is not set and the hook is loaded, when the auth call runs it ends up generating a php warning and no debug output.

The attached patch resolves the issue.
Comment 1 Damian Z 2012-08-24 01:27:11 UTC 
https://gerrit.wikimedia.org/r/#/c/21309/
Comment 2 Damian Z 2012-09-04 18:58:59 UTC 
Change merged.
Comment 3 Ryan Lane 2012-09-04 19:05:34 UTC 
That change is broken. Please see inline comments.
Comment 4 Damian Z 2012-09-04 19:31:29 UTC 
Oops, fix in https://gerrit.wikimedia.org/r/22615.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links