Last modified: 2012-02-29 20:58:04 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T36790, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 34790 - [Regression] Pressing "Make Request" shouldn't make two requests to api.php
[Regression] Pressing "Make Request" shouldn't make two requests to api.php
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
ApiSandbox (Other open bugs)
unspecified
All All
: Low normal (vote)
: ---
Assigned To: Krinkle
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2012-02-29 10:27 UTC by Antoine "hashar" Musso (WMF)
Modified: 2012-02-29 20:58 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Antoine "hashar" Musso (WMF) 2012-02-29 10:27:29 UTC 
When ever we submit the request to the API using the [Make Request] button, two ajax queries are sent to api.php.
Comment 1 Antoine "hashar" Musso (WMF) 2012-02-29 10:39:50 UTC 
Bisected to r109726 by Krinkle
Comment 2 Sam Reed (reedy) 2012-02-29 13:40:41 UTC 
(In reply to comment #0)
> When ever we submit the request to the API using the [Make Request] button, two
> ajax queries are sent to api.php.

2 identical requests?
Comment 3 Antoine "hashar" Musso (WMF) 2012-02-29 13:42:10 UTC 
Well two identical HTTP GET queries are made, something like:

GET api.php?action=foo&parameter1=bar
GET api.php?action=foo&parameter1=bar

So we are doubling the API bandwidth here :-)
Comment 4 Sam Reed (reedy) 2012-02-29 14:08:36 UTC 
(In reply to comment #3)
> Well two identical HTTP GET queries are made, something like:
> 
> GET api.php?action=foo&parameter1=bar
> GET api.php?action=foo&parameter1=bar
> 
> So we are doubling the API bandwidth here :-)

Ok, just wanting to make sure it wasn't some other "useful" but different side query :)
Comment 5 Krinkle 2012-02-29 18:05:35 UTC 
Fixed in r112702.
Comment 6 Antoine "hashar" Musso (WMF) 2012-02-29 20:58:04 UTC 
r112702 was troubling to subversion and got reverted.

Fix reapplied with r112721
Merged to 1.19wmf1 with r112723
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links