Last modified: 2012-03-01 21:51:47 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T36795, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 34795 - commonswiki.globalimagelinks.gil_page_title contains page titles with whitespace instead of underscores
commonswiki.globalimagelinks.gil_page_title contains page titles with whitesp...
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
GlobalUsage (Other open bugs)
unspecified
All All
: High normal (vote)
: ---
Assigned To: Sam Reed (reedy)
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-02-29 14:04 UTC by merl
Modified: 2012-03-01 21:51 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description merl 2012-02-29 14:04:51 UTC
Field commonswiki.globalimagelinks.gil_page_title should normally contain page titles using underscores as all page tables do. But sometimes white spaces are used instead. This config should be changed because it makes querying this table difficult if regex instead of simple string compare must be used to match all cases.

This behavior is new, so it may be related to 1.19 update of commonswiki.

Example: dewiki with underscore; eswiki,frwiki with white spaces

select gil_wiki, gil_page, gil_page_title, gil_to from commonswiki_p.globalimagelinks where gil_to='Castillo_de_Consuegra2.jpg';
+----------+----------+-----------------------+----------------------------+
| gil_wiki | gil_page | gil_page_title        | gil_to                     |
+----------+----------+-----------------------+----------------------------+
| dewiki   |  6794830 | Castillo_de_Consuegra | Castillo_de_Consuegra2.jpg |
| eswiki   |   581556 | Castillo de la Muela  | Castillo_de_Consuegra2.jpg |
| frwiki   |  5677515 | Château de la Muela   | Castillo_de_Consuegra2.jpg |
+----------+----------+-----------------------+----------------------------+
Comment 1 Sam Reed (reedy) 2012-02-29 14:17:25 UTC
Pushed into the extension component for the moment. Needs fixing before we look at trying to clean up post it...
Comment 2 Sam Reed (reedy) 2012-02-29 14:26:39 UTC
r112687, merged in r112688

This code is the same as it was in 1.18wmf1, so I'm not sure it's at fault, as it's only used on a page move
Comment 3 Sam Reed (reedy) 2012-02-29 14:35:57 UTC
Reproduced, I think...

Created a page (with the image) on enwiki at User:Reedy/Sandbox, moved to User:Reedy/Sandbox 2, it had a space

Deleted that page, recreated it from scratch, it had a _


Just the cleanup to do now...
Comment 4 Sam Reed (reedy) 2012-02-29 14:37:13 UTC
Merged to 1.18wmf1 in r112689
Comment 5 Sam Reed (reedy) 2012-02-29 15:17:52 UTC
Lowering severity as it's not going to get any worse

Running a large database query to pull a list of titles we need to fix
Comment 6 Sam Reed (reedy) 2012-02-29 23:42:51 UTC
Just under 55k to fix
Comment 7 Sam Reed (reedy) 2012-03-01 21:51:09 UTC
SELECT * FROM globalimagelinks WHERE gil_page_title LIKE '% %';


All done and tidied up now

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links