Last modified: 2012-03-09 03:58:35 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T36804, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 34804 - $sdgNumResultsPerPage ignored (limit and offset not set)
$sdgNumResultsPerPage ignored (limit and offset not set)
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
SemanticDrilldown (Other open bugs)
unspecified
All All
: Unprioritized normal (vote)
: ---
Assigned To: Yaron Koren
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2012-02-29 18:07 UTC by Paul Oranje
Modified: 2012-03-09 03:58 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
fix for the bug (1.30 KB, application/octet-stream)
2012-02-29 18:07 UTC, Paul Oranje 		Details
Add an attachment (proposed patch, testcase, etc.)

Description Paul Oranje 2012-02-29 18:07:05 UTC 
Created attachment 10129 [details]
fix for the bug

When $sdgNumResultsPerPage is set the Special:BrowseData page ignores this setting. A quick analysis learned that the use of the SDBrowseDataPage:execute() function i.s.o. DoQuery (when mediwiki version >= 1.18) causes the limit and offset values not to be passed. The SDBrowseDataPage class should set these members of its base class QueryPage.

Added a patch.
Comment 1 Yaron Koren 2012-03-01 22:55:03 UTC 
Is this still an issue with the latest SVN version of Semantic Drilldown?
Comment 2 Paul Oranje 2012-03-02 11:52:35 UTC 
Problem still present in SD trunk r112877.
Comment 3 Yaron Koren 2012-03-09 03:58:35 UTC 
Hi, sorry for the delay, and thanks for the fix - I was able to reproduce the problem, and your patch took care of it. I just checked it in to SVN - marking this bug as "fixed".
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links