Last modified: 2012-06-23 14:05:20 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T36815, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 34815 - QUnit filter for 'mediawiki.js' shouldn't run other mediawiki.* modules
QUnit filter for 'mediawiki.js' shouldn't run other mediawiki.* modules
Status: RESOLVED FIXED
Product: Wikimedia
Classification: Unclassified
Continuous integration (Other open bugs)
unspecified
All All
: Normal enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-02-29 21:21 UTC by Krinkle
Modified: 2012-06-23 14:05 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Krinkle 2012-02-29 21:21:42 UTC
QUnit's module filter unfortunately isn't really much of a module filter as it is a prefix filter.

Every test has a name (modulename + test name), and QUnit's prefix filter is applied to allow both filtering of modules and individual tests at the same time.

Can be fixed by calling module('filename') instead of module('filename without ".js"').

(assuming we don't have a module name ending in .js and another one that has .js and something after it) - even if we do, it would trim the issue down a lot.

Now a lot of tests are run twice (once under filter=mediawiki.util and again with filter=mediawiki).
Comment 1 Krinkle 2012-06-07 16:01:07 UTC
Part of https://github.com/jquery/qunit/issues/252
Comment 2 Krinkle 2012-06-23 14:04:57 UTC
Support upstream has been added, released and our copy has been updated. Now we need to actually use it. Moving to Wikimedia product.
Comment 3 Krinkle 2012-06-23 14:05:20 UTC
Ib0d81753b113243b492d216ff8c52812eb92dc08

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links