Last modified: 2012-03-23 02:10:31 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T36841, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 34841 - [Regression] Edit links seen on previous page versions


Summary:	[Regression] Edit links seen on previous page versions

Status:	RESOLVED FIXED

Product:	MediaWiki
Classification:	Unclassified
Component:	Page editing (Other open bugs)
Version:	1.19
Hardware:	All All

Importance:	Normal normal with 1 vote (vote)
Target Milestone:	1.19.0 release
Assigned To:	Peter Bena

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2012-03-01 04:00 UTC by Mark A. Hershberger
Modified:	2012-03-23 02:10 UTC (History)
CC List:	8 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Mark A. Hershberger 2012-03-01 04:00:20 UTC

From https://en.wikipedia.org/w/index.php?diff=479580769 :

when I'm looking at an old revision of a page there are edit section links available, however when I click on one it takes me to editing the same numbered section, but of the current revision, not the old revision that I was looking at (does that make sense?). So, is this a new thing or has it always been like that? 

It's new. It occurs for all sections on all pages I tested but an example can be good anyway: http://en.wikipedia.org/w/index.php?title=Wikipedia:Village_pump_%28technical%29&oldid=478913156#Article_counter currently has a section edit link saying http://en.wikipedia.org/w/index.php?title=Wikipedia:Village_pump_(technical)&action=edit&section=50.

Comment 1 Helder 2012-03-01 12:23:10 UTC

See also bug 33671.

Comment 2 Mark Hurd 2012-03-03 01:51:46 UTC

Yes, it should be 

http://en.wikipedia.org/w/index.php?title=Wikipedia:Village_pump_(technical)&action=edit&section=50&oldid=478913156

That is just add the &oldid=478913156 to the edit link.

Comment 3 Aaron Schulz 2012-03-14 00:43:54 UTC

I can't reproduce this on enwiki. I don't see [edit] links.

Comment 4 Bawolff (Brian Wolff) 2012-03-14 00:58:19 UTC

(In reply to comment #3)
> I can't reproduce this on enwiki. I don't see [edit] links.

I can reproduce using the link http://en.wikipedia.org/w/index.php?title=Wikipedia:Village_pump_%28technical%29&oldid=478913156#Article_counter


I can reproduce both logged in and logged out. Maybe you have some pref preventing them from appearing?

Comment 5 Aaron Schulz 2012-03-14 01:26:34 UTC

I do see the edit links on that link.

Comment 6 Peter Bena 2012-03-14 15:35:42 UTC

this is already fixed in trunk, we need to find it and merge it :)

Comment 7 Max Semenik 2012-03-14 15:52:52 UTC

Broken by r103502.

Comment 8 Alexandre Emsenhuber [IAlex] 2012-03-14 16:04:41 UTC

Fixed in r113816.

Comment 9 Mark Hurd 2012-03-23 02:10:31 UTC

I note this was resolved by removing the edit links again and although the correct (old) edit text appears if you do add the oldid parameter as I suggested, it is the right thing to not include these edit links at the moment because the edit is matched against the current version's same section number, as can be seen by clicking on my link above and then showing changes.

Nevertheless, for some pages, especially articles, where the sectioning doesn't change as much it does still seem like a good option, perhaps only available by a manually added parameter to the old revision URL.

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links