Last modified: 2012-07-09 18:49:43 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T36847, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 34847 - Keyboard accessible buttons
Keyboard accessible buttons
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
WikiEditor (Other open bugs)
unspecified
All All
: Normal normal (vote)
: MW 1.20 version
Assigned To: Nobody - You can work on this!
: patch, patch-need-review
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2012-03-01 11:47 UTC by Kai Nissen
Modified: 2012-07-09 18:49 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Patch to make the WikiEditor buttons accessible by keyboard (582 bytes, patch)
2012-03-01 11:47 UTC, Kai Nissen 		Details
Add an attachment (proposed patch, testcase, etc.)

Description Kai Nissen 2012-03-01 11:47:27 UTC 
Created attachment 10145 [details]
Patch to make the WikiEditor buttons accessible by keyboard

According to paragraph 2.1.1.3 of the accessibility report (http://www.thirdageonline.eu/project-tao-2/software-development/mediawiki-accessibility-enhancements/) the buttons for manipulating the text appearance in WikiEditor have to be accessible by the keyboard using the TAB key.

I propose the attached patch to enhance the accessibility. It declares the buttons as 'a' tags instead of 'span' and also adds an empty 'href' attribute.
Comment 1 Sumana Harihareswara 2012-05-23 19:52:43 UTC 
Kai, thanks for the patch!  You will get your patch reviewed faster if you use your Developer access

https://www.mediawiki.org/wiki/Developer_access

and submit your change directly into our source control system:

https://www.mediawiki.org/wiki/Git/Workflow

so please do. :-)  Thanks.
Comment 2 Kai Nissen 2012-06-02 11:56:34 UTC 
Done.

https://gerrit.wikimedia.org/r/#/c/9751/
Comment 3 Derk-Jan Hartman 2012-07-03 11:17:13 UTC 
this has been merged. Closing as fixed
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links