Last modified: 2014-03-11 14:31:59 UTC
After some reports of broken gadgets on Portuguese Wikipedia, I noticed that they were failing because one of the default gadgets was defined by * Topicon[ResourceLoader|default|dependencies=jquery.mwPrototypes]|Topicon.js|Topicon.css which worked fine on MW 1.18, and then stoped working on MW 1.19 because the module was renamed to "jquery.mwExtension" on r94227. This was fixed by updating the definition: https://pt.wikipedia.org/w/index.php?title=MediaWiki%3AGadgets-definition&diff=29150779&oldid=29083316 But the point is: the unknown dependency was breaking not only that (default) script, but other gadgets as well. You can check this by defining a dummy gadget by means of a line such as * bug-test[ResourceLoader|dependencies=foo.bar]|bug-test.js https://pt.wikibooks.org/w/index.php?title=MediaWiki%3AGadgets-definition&action=historysubmit&diff=233968&oldid=233722 and enable it together with some other gadget (e.g. the UTCLiveClock, which is working fine). There will be an error like this: > Uncaught Error: Unknown dependency: foo.bar and the other gadget won't work.
Rephrasing bug and moving to MediaWiki core > ResourceLoader. The gadgets (and other modules as well), are loaded from the html page with mw.loader.load(), passing it an array of module names. Among them gadget.Topicon and what not. By default modules loaded in the same batch are related (e.g. a dependency resolution, or a call to mw.loader.using() ). But calls to mw.loader.load() shouldn't be treated like that.
Not a lot of gadgets on third party wikis, so I don't think this is going to be a major blocker for 1.19 tarball release. Adjusting milestone.
I have seen this in 1.19, but, yes, not a huge issue. Bumping to nebulous future.
Two years ago, Krinkle assigned this ticket to Roan and set the status to ASSIGNED. Roan: Are you still working (or still plan to work) on this issue? In case you do not plan to work on this issue anymore, should the assignee be set back to default and the bug status changed from ASSIGNED to NEW/UNCONFIRMED? Thanks. (In reply to Mark A. Hershberger from comment #3) > not a huge issue. -> Changing priority from high to normal.
