Last modified: 2012-03-02 20:40:13 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T36854, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 34854 - File history tables no longer wrap summaries in <span class="comment">
File history tables no longer wrap summaries in <span class="comment">
Status: RESOLVED WONTFIX
Product: MediaWiki
Classification: Unclassified
File management (Other open bugs)
1.19
All All
: Normal minor (vote)
: 1.19.0 release
Assigned To: Nobody - You can work on this!
: code-update-regression
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-03-01 15:32 UTC by hurricanefan25.wikipedia
Modified: 2012-03-02 20:40 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description hurricanefan25.wikipedia 2012-03-01 15:32:31 UTC
Same as title. MW 1.19
Comment 1 Antoine "hashar" Musso (WMF) 2012-03-01 16:37:16 UTC
It never did in MediaWiki. I have checked 1.18, 1.19 and trunk.

On which wiki have you met this issue?  It must be a local modification.
Comment 2 Bawolff (Brian Wolff) 2012-03-02 20:31:24 UTC
I think this is my fault (r103362)...


The image file history table used to call some method that would wrap the comment in (<span class="comment"> [comment here]</span>). The brackets looked kind of stupid given the image was in a table, and got removed somewhere along the line.

The comment class made things italic as well I believe.


With that said, I don't necessarily think this change is a bad thing. Offsetting something in italics that is already offset by a table cell seems to be not the nicest design imho.
Comment 3 Antoine "hashar" Musso (WMF) 2012-03-02 20:40:13 UTC
Thanks bawolff for the explanation. I agree with you, applying a "comment" class to a table summary does not make any sense. 

If a wiki really wants to apply a specific style there they can use  "table.filehistory > th".

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links