Last modified: 2013-02-10 08:02:44 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T36904, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 34904 - CSS-only gadgets enabled shouldn't be loaded via mw.loader.load
CSS-only gadgets enabled shouldn't be loaded via mw.loader.load
Status: NEW
Product: MediaWiki extensions
Classification: Unclassified
Gadgets (Other open bugs)
unspecified
All All
: Normal enhancement (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-03-02 20:17 UTC by db [inactive,noenotif]
Modified: 2013-02-10 08:02 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description db [inactive,noenotif] 2012-03-02 20:17:10 UTC
When a gadget only has css files, it get a loader.load entry. In my opinion it is easy/cheap to check, if the gadget has only css files and than skip that entry, because the css should be enough to get. Thanks.
Comment 1 Krinkle 2012-03-02 20:39:34 UTC
(In reply to comment #0)
> When a gadget only has css files, it get a loader.load entry. In my opinion it
> is easy/cheap to check, if the gadget has only css files and than skip that
> entry, because the css should be enough to get. Thanks.

Then how do you suggest the CSS actually ends up in the client ?

mw.loader requests modules in batch from load.php based on the dependency model and current last-modified timestamps from the startup module.

load.php then responses with the requested modules and their 3 components (of which some could be empty/undefined): JS function, CSS stylesheet, i18n messages. These are then unpackaged on the client (e.g. style is inserted into the <style> tag).

What is your suggestions exactly?
Comment 2 db [inactive,noenotif] 2012-03-02 20:55:28 UTC
CSS is loaded with a <link rel="stylesheet" href="//.../load.php?debug=false&..." type="text/css" media="all" />.

There is no need for a javascript part.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links