Last modified: 2012-03-13 20:40:06 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T36972, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 34972 - [Regression] An error occurred while changing your watchlist settings for [[Special:WhatLinksHere/Example]]


Summary:	[Regression] An error occurred while changing your watchlist settings for [[S...

Status:	RESOLVED FIXED

Product:	MediaWiki
Classification:	Unclassified
Component:	Watchlist (Other open bugs)
Version:	1.19
Hardware:	All All

Importance:	High normal (vote)
Target Milestone:	1.19.0 release
Assigned To:	Nobody - You can work on this!

URL:	https://en.wikipedia.org/wiki/Special...
Whiteboard:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2012-03-04 20:58 UTC by Helder
Modified:	2012-03-13 20:40 UTC (History)
CC List:	3 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
proposed patch (2.43 KB, patch) 2012-03-09 00:19 UTC, Kevin Israel (PleaseStand)	Details
proposed patch (2.54 KB, patch) 2012-03-09 04:30 UTC, Kevin Israel (PleaseStand)	Details
Show Obsolete (1) Add an attachment (proposed patch, testcase, etc.)

Description Helder 2012-03-04 20:58:02 UTC

If I go to a page such as
https://en.wikipedia.org/wiki/Special:WhatLinksHere/Example
and click on watch I always get
"An error occurred while changing your watchlist settings for "[[Special:WhatLinksHere/Example]]"."

I don't remember seing this on MW 1.18.

Comment 1 Kevin Israel (PleaseStand) 2012-03-09 00:19:25 UTC

Created attachment 10202 [details]
proposed patch

AJAX watching did not work on Special:MovePage and Special:WhatLinksHere
because the API requests would contain the name of the special page
instead of a wiki page's name; adding a configuration variable with that
information (and using it when watching pages via AJAX) can fix this problem.

At least in Wikimedia's case, logged-in users (who are the only users able
to watch pages) bypass the Squid cache, so using the newly introduced
variable should not pose a problem.

Comment 2 Kevin Israel (PleaseStand) 2012-03-09 04:30:50 UTC

Created attachment 10203 [details]
proposed patch

Fixing my patch. MediaWiki still sends 304 Not Modified headers, so the JavaScript would still have to fall back to wgPageName if necessary.

Comment 3 Rob Moen 2012-03-13 17:58:18 UTC

Thanks for the patch!  Applied in trunk r113737

Comment 4 Brion Vibber 2012-03-13 20:40:06 UTC

Removing patch, need-review keywords

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links