Last modified: 2013-10-23 18:16:58 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T37032, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 35032 - UploadFromStash is broken in 1.18.1
UploadFromStash is broken in 1.18.1
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
File management (Other open bugs)
1.18.x
All All
: Normal major (vote)
: 1.18.x release
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-03-07 13:22 UTC by Vitaliy Filippov
Modified: 2013-10-23 18:16 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Vitaliy Filippov 2012-03-07 13:22:07 UTC
UploadFromStash is broken in MediaWiki 1.18.1.
So when you try uploading a file and it fails with a warning (for example ...this file is a duplicate of...), clicking both "Submit modified file description" and "Ignore warning and save file anyway" buttons don't work - you just get an empty upload form after it.
This bug can be fixed by taking includes/upload/UploadFromStash.php and includes/upload/UploadStash.php from trunk r105822.
Marking this bug major as MediaWiki 1.18.1 is listed as stable. The fix probably needs queueing for 1.18.2.
Comment 1 Mark A. Hershberger 2012-03-08 20:56:18 UTC
If you can provide a patch for this we'll look at merging it for a
1.18.2 tarball.
Comment 2 Andy Lester 2012-03-09 16:08:27 UTC
Thanks for posting this here.  This fixed my problem.
Comment 3 Sam Reed (reedy) 2012-03-09 16:27:15 UTC
(In reply to comment #1)
> If you can provide a patch for this we'll look at merging it for a
> 1.18.2 tarball.

It can just be done now, then it's there if/when we have a 1.18.2 release. Saves scrambling around looking for these bugs in the run up to release =)

(In reply to comment #0)
> This bug can be fixed by taking includes/upload/UploadFromStash.php and
> includes/upload/UploadStash.php from trunk r105822.
> Marking this bug major as MediaWiki 1.18.1 is listed as stable. The fix
> probably needs queueing for 1.18.2.

Although maybe the easiest way, blindly copying from trunk doesn't sounds like the best way..

Done in r113481

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links