Last modified: 2012-03-16 10:40:37 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T37051, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 35051 - [Regression] If heading has a trailing space after == then its name is not preloaded into edit summary on section edit
[Regression] If heading has a trailing space after == then its name is not pr...
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Page editing (Other open bugs)
1.19
All All
: Normal normal (vote)
: 1.19.0 release
Assigned To: Nobody - You can work on this!
: code-update-regression
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-03-08 03:45 UTC by Bawolff (Brian Wolff)
Modified: 2012-03-16 10:40 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Bawolff (Brian Wolff) 2012-03-08 03:45:31 UTC
For a == header == heading. If there's a trailing space after the closing ==, then the header is not properly included in default edit summary for section edits

Steps to reproduce:

Create a page with the following

== h ==<sp>
foo

(Replacing the <sp> with a space. So there should be 1 trailing space after the closing ==. The foo on the next line is to prevent parser from stripping that space).

Edit section 1.

Expected behaviour:

Edit summary defaults to /* H */

Actual behaviour:

Edit summary defaults to being empty.


I checked, and this issue was not present on 1.18.


Originally reported by PiZero on irc for the url https://en.wikinews.org/w/index.php?title=Wikinews_interviews_Americans_Elect_presidential_candidate_Mike_Ballantine&action=edit&section=1
Comment 1 Max Semenik 2012-03-08 18:36:42 UTC
Broken by r105380, fixmed.
Comment 2 Mark A. Hershberger 2012-03-14 15:23:08 UTC
http://winkyfrown.com/wiki/index.php?title=Bug_35051&action=edit&section=1 -- looks fixed
Comment 3 Bawolff (Brian Wolff) 2012-03-14 18:07:13 UTC
(In reply to comment #2)
> http://winkyfrown.com/wiki/index.php?title=Bug_35051&action=edit&section=1 --
> looks fixed

Doesn't seem like there was a space after the header in that example. I added one and the problem appears there.
Comment 4 Max Semenik 2012-03-15 15:23:37 UTC
Fixed in r113922.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links