Last modified: 2012-03-08 09:47:18 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T37058, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 35058 - [Regression] Don't prepend 2 empty lines before the Welcome template
[Regression] Don't prepend 2 empty lines before the Welcome template
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
NewUserMessage (Other open bugs)
unspecified
All All
: Normal normal (vote)
: MW 1.19 version
Assigned To: Krinkle
: code-update-regression
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-03-08 09:44 UTC by Krinkle
Modified: 2012-03-08 09:47 UTC (History)
0 users

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Krinkle 2012-03-08 09:44:24 UTC
The extension prepends an empty line before the template, twice.

* One: Presumably in case there is content on the page already, however the extension doesn't reach this code in that case since it returns early if $talk->exists(), and even then, it should only insert the new line in case it exists at point of saving).

* One: To create space between the (optional!) subject header.

This is also causing a visual gap on top of the user talk page:

Example:
* https://commons.wikimedia.org/w/index.php?title=User_talk:Globatlas_adventures&oldid=68039348
* https://commons.wikimedia.org/w/index.php?title=User_talk:Globatlas_adventures&action=edit

Proposing to:
* Move the first newline to where it detects the page already exists, away from the all-case that in (so far) 100% cases is never reached, fixing the first new line
* Move the second new line to within the if(subject) block, fixing the second one.
Comment 1 Krinkle 2012-03-08 09:47:18 UTC
Fixed in r113352.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links