Last modified: 2014-05-24 02:23:20 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T37067, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 35067 - Provide an easy way to get a diff against an old revision of a page while editing it
Provide an easy way to get a diff against an old revision of a page while edi...
Status: PATCH_TO_REVIEW
Product: MediaWiki
Classification: Unclassified
History/Diffs (Other open bugs)
1.19
All All
: Normal enhancement (vote)
: ---
Assigned To: JuneHyeon Bae (devunt)
: design, easy
: 41307 (view as bug list)
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-03-08 12:44 UTC by Helder
Modified: 2014-05-24 02:23 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Helder 2012-03-08 12:44:02 UTC
Suppose someone makes a big change on page [[Foo]] or [[Template:Bar]], and gets reverted because some other user found a problem in the new revision. The first user may want to improve its original change, and to do that, he/she may open his/her old version from the page history (i.e., oldid=12345) and then open that old revision for edit (oldid=12345&action=edit).
Once the updates are finished, though, there is no way to get a diff of what he/she changed since the last try. He/she will need to save the page first, and only then to get a diff.

So, I think it would be good to provide a new button [Show changes since this old revision] on the right side of the existing [Show changes], when editing an old version of a page.

See also bug 29674.
Comment 1 Brad Jorsch 2012-10-26 01:54:53 UTC
*** Bug 41307 has been marked as a duplicate of this bug. ***
Comment 2 Helder 2012-10-26 03:03:02 UTC
This should be easy since the difference between the two features is exactly what is shown on Gerrit change #30113:
https://gerrit.wikimedia.org/r/#/c/30113/1/includes/EditPage.php,unified
Comment 3 Helder 2013-03-14 12:07:35 UTC
Copying from bug 41307:
----
If a user open an old revision of a page in edit mode and then click on [Show
changes], it will be displayed a diff against the most recent version of the
page and not against the version he was editing (sometimes it is this diff
which the user wants).

Such a feature is available in [[User:Js/ajaxPreview#Extra_features]], and is
very useful.

See also bug 29674.
----
Comment 4 PiRSquared17 2014-04-21 15:56:23 UTC
Doesn't "undo" give a diff?
Comment 5 Helder 2014-04-22 15:37:45 UTC
(In reply to PiRSquared17 from comment #4)
> Doesn't "undo" give a diff?

If I go to
https://en.wikipedia.org/Wikipedia:Sandbox?action=edit&oldid=605309723
and change "Test 1" to "Test 3", there is no "undo" feature which I could use to get a diff (and the button "Show changes" will make a diff against the most recent version of the page, which is not what I want).
Comment 6 Gerrit Notification Bot 2014-05-24 02:23:18 UTC
Change 135165 had a related patch set uploaded by devunt:
Add "Show changes against previous revision" button

https://gerrit.wikimedia.org/r/135165

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links