Last modified: 2013-03-19 20:05:01 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T37070, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 35070 - Blanking a LiquidThreads post commits successfully when disallowed
Blanking a LiquidThreads post commits successfully when disallowed
Status: REOPENED
Product: MediaWiki extensions
Classification: Unclassified
LiquidThreads (Other open bugs)
unspecified
All All
: Low normal with 1 vote (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-03-08 17:52 UTC by Rob Schnautz
Modified: 2013-03-19 20:05 UTC (History)
6 users (show)

See Also:
Web browser: Firefox
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Rob Schnautz 2012-03-08 17:52:18 UTC
Steps to reproduce:

1. User without comment deletion privilege edits a post.
2. Post is blanked (including title, if applicable), leaving an edit summary of why they retracted their comment.
3. Post is saved.
4. Dialog appears indicating the user may not blank a post.
5. Post blanking commits successfully.
Comment 1 Mark A. Hershberger 2012-03-08 21:02:20 UTC
Seems like this is working as it is supposed to.
Comment 2 Andrew Garrett 2012-03-08 21:39:40 UTC
This is expected behaviour.
Comment 3 Rob Schnautz 2012-03-08 21:55:39 UTC
Except I've been able to reproduce it consistently. Something's definitely wrong here.
Comment 4 Jeroen De Dauw 2012-03-08 22:11:47 UTC
Expected behavior? Either you allow it and don't show it's not allowed, or you don't allow it and actually prevent it. Doing a combination of both seems unreasonable to me...
Comment 5 Mark A. Hershberger 2012-03-09 03:05:25 UTC
(In reply to comment #3)
> Except I've been able to reproduce it consistently. Something's definitely
> wrong here.

What do you think should happen?
Comment 6 Rob Schnautz 2012-03-09 15:34:59 UTC
Mark, it seems straightforward to me:

If a user is told they're unable to blank, they shouldn't be able to blank. The edit shouldn't commit, and the edit dialog should remain open instead.
Comment 7 Mark A. Hershberger 2012-03-09 21:38:09 UTC
(In reply to comment #6)
> If a user is told they're unable to blank, they shouldn't be able to blank.

Deletion is different than blanking.

It took some time, but I was able to delete a post by blanking it.  Usually, even with funny Unicode characters like "em-space", I got a notice saying that I couldn't create an empty title or any empty post.

Now that I have been able to sporadically duplicate what you saw, I'm giving this to Chris McMahon to see if he can get a better reproduction.
Comment 8 Mark A. Hershberger 2012-03-09 21:41:04 UTC
(In reply to comment #7)
> Now that I have been able to sporadically duplicate what you saw, I'm giving
> this to Chris McMahon to see if he can get a better reproduction.

I tested this here: 
https://www.mediawiki.org/wiki/User:MarkAHershberger/lqt-test

There is only one topic open with the subject removed by my test user ("Hexmode").  There was another topic open which my test user was (after a bit of trying) able to remove.
Comment 9 Valerie Juarez 2013-03-19 20:05:01 UTC
Can confirm. 

I was able to delete the thread 'Starting a new discussion?' by blanking out the body and title. I got a message "You cannot post a blank message" but it went through anyway.

See history: https://test2.wikipedia.org/w/index.php?title=Talk:Xpd&lqt_method=talkpage_history
The last Activity in thread 'Starting a new discussion?' is 'Removed comment text'. This is where I blanked out the message.

And current talk page: https://test2.wikipedia.org/wiki/Talk:Xpd has no thread called 'Starting a new discussion?'.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links