Last modified: 2014-01-31 14:00:39 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T37071, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 35071 - mediawiki.action.edit.js always setting legacy function
mediawiki.action.edit.js always setting legacy function
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
JavaScript (Other open bugs)
unspecified
All All
: Low normal with 1 vote (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2012-03-08 18:36 UTC by db [inactive,noenotif]
Modified: 2014-01-31 14:00 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description db [inactive,noenotif] 2012-03-08 18:36:47 UTC 
mediawiki.action.edit.js is always polluting the global scope by

window.addButton = toolbar.addButton; 
window.insertTags = toolbar.insertTags;

What about respecting $wgIncludeLegacyJavaScript (or $wgLegacyJavaScriptGlobals)? Thanks.
Comment 1 Helder 2014-01-30 17:28:46 UTC 
This is kind of fixed since window.addButton and window.insertTags were deprecated on Gerrit change #95764.
https://git.wikimedia.org/blob/mediawiki%2Fcore.git/a6f0a996ebe55496dda685da750f08f0b02bca14/resources%2Fmediawiki.action%2Fmediawiki.action.edit.js#L132
Comment 2 Bartosz Dziewoński 2014-01-30 17:30:00 UTC 
Yeah, that's probably as 'fixed' as this is going to get. Thoughts?
Comment 3 Helder 2014-01-30 17:37:55 UTC 
Should we wait until the deprecated code is actually removed to consider this as fixed?
Comment 4 db [inactive,noenotif] 2014-01-31 14:00:39 UTC 
A deprecated function is no longer legacy, so this bug is fixed ;-)

No tracking bug for this is needed, because deprecated function will be removed anytime by a volunteer, so all okay here.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links