Last modified: 2012-03-11 21:49:57 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T37156, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 35156 - Harmonise spelling of getArticleID() and getArticleId()


Summary:	Harmonise spelling of getArticleID() and getArticleId()

Status:	RESOLVED FIXED

Product:	MediaWiki
Classification:	Unclassified
Component:	General/Unknown (Other open bugs)
Version:	1.20.x
Hardware:	All All

Importance:	Low normal (vote)
Target Milestone:	---
Assigned To:	Nobody - You can work on this!

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2012-03-11 18:55 UTC by T. Gries
Modified:	2012-03-11 21:49 UTC (History)
CC List:	0 users

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description T. Gries 2012-03-11 18:55:34 UTC

I found different spellings of the get ArticleId method in different locations and contexts. In my view, this should be harmonised.

For example, in Title.php line 2541 

array( 'page_id' => $this->getArticleId() ), __METHOD__ );
if ( $oldSubpage->getArticleId() == $this->getArticleId() ||
$oldSubpage->getArticleID() == $nt->getArticleId() )

158 usages of getArticleId in our repo

Spelling should be harmonised, in my view.

See discussion today in #wikitech .

Comment 1 Sam Reed (reedy) 2012-03-11 19:31:24 UTC

(In reply to comment #0)
> See discussion today in #wikitech .

#mediawik

r113580, r113583

Comment 2 T. Gries 2012-03-11 20:13:22 UTC

I cannot see changes in Title.php and some other modules.

includes> grep -l getArticleId *
EditPage.php
Revision.php
Skin.php
SkinLegacy.php
SkinTemplate.php
Title.php
WikiPage.php
addCategory


But I haven't checked in detail.

Comment 3 Sam Reed (reedy) 2012-03-11 21:49:57 UTC

(In reply to comment #2)
> I cannot see changes in Title.php and some other modules.
> 
> includes> grep -l getArticleId *
> EditPage.php
> Revision.php
> Skin.php
> SkinLegacy.php
> SkinTemplate.php
> Title.php
> WikiPage.php
> addCategory
> 
> 
> But I haven't checked in detail.

I can't find any more exactly like "getArticleId"

Sounds like your working copy is out of date

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links