Last modified: 2012-03-12 18:56:53 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T37162, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 35162 - Change in Database api break extension MSSQLBackCompat
Change in Database api break extension MSSQLBackCompat
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Database (Other open bugs)
unspecified
All All
: Unprioritized normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-03-11 23:31 UTC by Solitarius
Modified: 2012-03-12 18:56 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Solitarius 2012-03-11 23:31:15 UTC
DatabaseMssqlold::__construct is being called with one parameters while it expect 4 to 6 parameters.

I believes the changes in Database:factory, especially around the code 

elseif ( class_exists( $class ) && is_subclass_of( $class, 'DatabaseBase' ) ) {
        return new $class( $p );
Comment 1 Sam Reed (reedy) 2012-03-11 23:41:20 UTC
r113601
Comment 2 Solitarius 2012-03-11 23:50:26 UTC
Changing 
        new $class( $p )

to
        new $class( $p['host'], $p['user'], $p['password'], $p['dbname'] )

didn't seem to make it working. Could the object be create, the connection create but the query not passing on to the database object?
Comment 3 Solitarius 2012-03-12 18:09:53 UTC
This is probably not the right place to put this, but I want to note it somewhere.

The issue only occur when there is accented characters in the WHERE clause of the SELECT query. Perhaps $wgDBmysql5?
Comment 4 Sam Reed (reedy) 2012-03-12 18:56:53 UTC
(In reply to comment #3)
> This is probably not the right place to put this, but I want to note it
> somewhere.
> 
> The issue only occur when there is accented characters in the WHERE clause of
> the SELECT query. Perhaps $wgDBmysql5?

What does?

wgDBmysql5 shouldn't affect MSSQL...

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links