Last modified: 2012-05-17 02:04:33 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T37202, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 35202 - Pending changes diff is centered
Pending changes diff is centered
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
FlaggedRevs (Other open bugs)
unspecified
All All
: Low normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-03-13 17:29 UTC by AlexSm
Modified: 2012-05-17 02:04 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Pending changes (collapsed) diff is centered (9.95 KB, image/png)
2012-03-13 17:29 UTC, AlexSm
Details

Description AlexSm 2012-03-13 17:29:36 UTC
Created attachment 10229 [details]
Pending changes (collapsed) diff is centered

"Pending changes diff" text is centered (see the attachment).

To recreate the problem:
* have editor flag
* check "Show the pending changes diff when viewing the latest pending revision" in preferences
* visit any page with pending changes and click "show those changes"

Depending on how you get to the page the diff table is inside either div.flaggedrevs_preview or div.flaggedrevs_basic both of which have "text-align:center" in ext.flaggedRevs.basic.css

As a temporary workaround we had to add this to ru:MediaWiki:Common.css:
#mw-fr-stablediff {text-align: left}
Comment 1 Aaron Schulz 2012-03-14 17:47:39 UTC
Why is this a problem?
Comment 2 AlexSm 2012-03-15 14:29:21 UTC
1. It's plain inconvenient: the text in NOT centered in any other diffs.

2. It's a regression from MW 1.18.

3. It doesn't respect "justify paragraphs" option in preferences.
Comment 3 Aaron Schulz 2012-04-05 19:15:28 UTC
I can't find any FR changes to cause this, so it must have been some side-effect of a core change.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links