Last modified: 2012-06-10 01:00:55 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T37208, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 35208 - "Further results" does not respect "named args" (1.7.1)
"Further results" does not respect "named args" (1.7.1)
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
Semantic MediaWiki (Other open bugs)
unspecified
All All
: Unprioritized normal (vote)
: ---
Assigned To: Nobody - You can work on this!
: patch, patch-need-review
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-03-13 22:03 UTC by Van de Bugger
Modified: 2012-06-10 01:00 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Patch. (557 bytes, patch)
2012-03-13 22:03 UTC, Van de Bugger
Details

Description Van de Bugger 2012-03-13 22:03:46 UTC
Created attachment 10231 [details]
Patch.

I have inline query:

{{ #ask: ...
| format = ul
| template = Item
| named args = yes
...
}}

Result looks ok, but following "further results" link shows nothing. I found that link to Special:Ask does not include "named args" parameter. I fixed SMW_QP_List.php file (patch attached), so Special:Ask now receives "named args".
Comment 1 Van de Bugger 2012-03-13 22:19:59 UTC
However, the patch does not solve the problem completely. There is one more problem in name of the first column. Following inline query

{{ #ask: 
| ?# = main <!-- Note this -->
| format = ul
| template = Item
| named args = yes
...
}}

passes "?main" parameter to template "Item". But when the same template is called from "Special:Ask", it does not receive "?main" parameter.

Adding "mainlabel" changes the situation a little bit:

{{ #ask: 
| ?# = main <!-- Note this -->
| mainlabel = main
| format = ul
| template = Item
| named args = yes
...
}}

In such a case template receives "main" parameter, but it is plain text in inline query and link in Special:Ask. 

I believe the template should receive exactly the same parameters in both cases.
Comment 2 Jeroen De Dauw 2012-06-10 01:00:55 UTC
SMW 1.8 now has generic parameter handling that places all provided parameters in further result links, so this should be fixed. Would be nice if you could confirm.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links