Last modified: 2012-03-16 11:55:41 UTC
Currently, whenever CR detects that a new revision refers to an old revision, it marks it as a follow-up and sends an e-mail to everyone connected to the old revision (committer, commenters, etc.). However, we have a multi-repository setup, and the revision we are referring to may actually be in a different repository. This means that about 25% of the time, the follow-up association will be wrong, resulting in a lot of e-mail spam. I have no problem with things being incorrectly associated - it is easy to dissociate them - but I want to disable the e-mails which are currently just a nuisance. I'm happy to make the fix myself, but I wanted to post the issue here to see if anyone had any thoughts about this before I implemented it. I was going to do this via a new global configuration setting - $wgCodeReviewDisableFollowUpNotification - which is checked prior to sending the e-mails. Sound sensible?
(In reply to comment #0) > I was going to do this via a new global configuration setting - > $wgCodeReviewDisableFollowUpNotification - which is checked prior to sending > the e-mails. Sound sensible? Hiding it behind a global should be fine, default it to true so no change in behaviour and take it from there
The above example is an option to disable the e-mail, so defaulting it to false will result in no change. Will proceed in this manner.
Setting added in r114011. Resolving as FIXED.
