Last modified: 2014-07-21 12:52:29 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T37241, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 35241 - take over jquery.tipsy plugin
take over jquery.tipsy plugin
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
JavaScript (Other open bugs)
unspecified
All All
: High enhancement (vote)
: ---
Assigned To: Antoine "hashar" Musso (WMF)
:
Depends on:
Blocks: 35212 33562
  Show dependency treegraph
 
Reported: 2012-03-15 07:23 UTC by Antoine "hashar" Musso (WMF)
Modified: 2014-07-21 12:52 UTC (History)
7 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Antoine "hashar" Musso (WMF) 2012-03-15 07:23:25 UTC
From my comment on bug 33562:

I guess upstream author abandoned or lost interest into the project. Despite 29
pull requests and several mails sent to his various email addresses, I have not
heard back from him.

I think we should take over the project and fork it under the wikimedia team on
Github. Merge the pull requests, include our changes. Then release a new
version making it clear we are taking over the project.
Comment 1 Antoine "hashar" Musso (WMF) 2012-03-15 07:26:19 UTC
We could either host it:
- on github under https://github.com/wikimedia
- with WMF Bugzilla and Gerrit
Comment 2 kipod 2012-03-15 13:48:13 UTC
agree 100%.

the only other sane option is to switch from tipsy and find another, maintained, plugin that provides this functionality.

i was not aware of these 29 pull requests - they should be handled very carefully. 
with high probability not all are good and some provide overlapping functionality.

peace.
Comment 3 kipod 2012-03-16 18:55:45 UTC
this is actually somewhat important - as mentioned in Bug #35212, tipsy contains few bugs (both the mediawiki version and the upstream head version). we should either take responsibility for this cute plugin, or find some maintained package to provide this functionality. 

i attached a version that deals with the bugs known to me to #35212, but it's not thoroughly tested.

peace.
Comment 4 Mark A. Hershberger 2012-03-18 16:57:14 UTC
(In reply to comment #3)
> this is actually somewhat important - as mentioned in Bug #35212, tipsy
> contains few bugs (both the mediawiki version and the upstream head version).

Bumping priority.
Comment 5 kipod 2012-04-20 20:49:37 UTC
Any news about this issue?

peace.
Comment 6 Antoine "hashar" Musso (WMF) 2012-04-23 09:29:00 UTC
Still no news from upstream and I personally don't have anytime to handle this issue.  This is most probably something that will need to be done by the WMF feature team.
Comment 7 Antoine "hashar" Musso (WMF) 2012-07-05 09:59:04 UTC
I have asked internally Tomasz Finc to have a new github repository created under https://github.com/wikimedia .
Comment 8 Antoine "hashar" Musso (WMF) 2012-07-06 19:23:52 UTC
The fork is now at https://github.com/wikimedia/jquery-tipsy with pull requests and issue tracker enabled. WMF staff should have read write access provided they are part of the wikimedia github team.

Thanks to Tomasz Finc for the fork help!
Comment 9 Tisza Gergő 2014-07-03 22:03:19 UTC
Did any work happen in the fork? From the github network graph it seems it is still identical to the original tipsy plugin; there is a semi-maintained fork under https://github.com/CloCkWeRX/tipsy which has lots of fixes applied.
Comment 10 Antoine "hashar" Musso (WMF) 2014-07-21 12:52:29 UTC
(In reply to Tisza Gergő from comment #9)
> Did any work happen in the fork? From the github network graph it seems it
> is still identical to the original tipsy plugin; there is a semi-maintained
> fork under https://github.com/CloCkWeRX/tipsy which has lots of fixes
> applied.


I don't think we did anything on the forked repository beside some linting as shown at:

 https://github.com/wikimedia/jquery-tipsy/commits/master

Our fork is really the code from mediawiki/core source code.

What could be done is:

- upstream mediawiki core changes to our repo wikimedia/jquery-tipsy
- triage / integrate pull requests from upstream https://github.com/jaz303/tipsy/pulls and integrate them in our fork
- whenever we have something nice/robust, cut a new release of the fork and update the version we have in mediawiki/core


That would be the open source way of doing things.  I am not sure we have any interest in maintaining jquery-tipsy though.   That is probably superseded by ooui.

Upstream author never replied to my mails and apparently gave up maintaining his repository.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links