Last modified: 2013-03-28 22:03:09 UTC
The new bidirectionality-improving div should only contain the parsed page content, nothing else. This is perfect when viewing articles, and helps scripts a lot when extracting that content. But I think it is only needed for article views. For example in diff mode, it contains <form id="mw-fr-reviewform"> <div id="mw-fr-diff-headeritems"> <table class="diff"> <hr class="diff-hr"/> <h2 class="diff-currentversion-title"> ...and then the real content Also, in edit mode the <div id="mw-content-text"> contains <div id="editnotice-ns-0"/> <div id="mw-edit-longpage-hint"> <div id="wikiPreview" class="ontop" style="display: none;"/> <form id="editform"> None of them is really content-text, I suspect. I think it would be better to have the div only appear (maybe empty) in the #wikiPreviw. Also, it for example broke my script which tried to document.getElementById("bodyContent").insertBefore(newElement, document.getElementById("editform"));
(In reply to comment #0) > Also, it for example broke my script which tried to > document.getElementById("bodyContent").insertBefore(newElement, > document.getElementById("editform")); Please elaborate what you mean here.
> > Also, it for example broke my script which tried to > > document.getElementById("bodyContent").insertBefore(newElement, > > document.getElementById("editform")); > > Please elaborate what you mean here. I have a script that inserted some edit tools into #bodyContent, right before #editform. Since r111647 that doesn't work, as #editform now is a child of #mw-content-text. OK, it was a minor issue and very easy to fix. I only wanted to mention that some tools may be broken that make assumptions about the child nodes of mw.util.$content, which might be quite common.
