Last modified: 2012-03-19 18:38:58 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T37267, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 35267 - My LCStore_Accel fails with APC
My LCStore_Accel fails with APC
Status: NEW
Product: MediaWiki
Classification: Unclassified
Internationalization (Other open bugs)
unspecified
All All
: Low normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2012-03-16 17:20 UTC by Vitaliy Filippov
Modified: 2012-03-19 18:38 UTC (History)
5 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Vitaliy Filippov 2012-03-16 17:20:17 UTC 
There is LCStore_Accel class which I have offered some time ago.
Now I've found a bug in it - a check for === null at LocalisationCache.php:358 doesn't work with APC cache (earlier I've tested it only with XCache), because it returns false instead of null.
357 	// Different keys may expire separately, at least in LCStore_Accel
358 	if ( $deps === null || $keys === null || $preload === null ) {

The check should probably look like !$deps || !$keys || !$preload.
Comment 1 Aaron Schulz 2012-03-16 17:37:22 UTC 
LCStore_Accel turns false into null on get(), so it should be OK. Seems to work for me.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links