Last modified: 2012-11-04 17:38:54 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T37303, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 35303 - DNSBL related block settings broken.
DNSBL related block settings broken.
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
User blocking (Other open bugs)
1.19
All All
: Unprioritized normal (vote)
: 1.19.0 release
Assigned To: Nobody - You can work on this!
:
: 34385 (view as bug list)
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-03-18 17:18 UTC by Bawolff (Brian Wolff)
Modified: 2012-11-04 17:38 UTC (History)
3 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Bawolff (Brian Wolff) 2012-03-18 17:18:12 UTC
The DNSBL related settings are broken.

If you're detected as being blacklisted, the following happens:

                                        $this->mBlockedby = wfMsg( 'sorbs' );
                                        $this->mBlockreason = wfMsg( 'sorbsreason' );

However, the actual methods to see if your blocked look for $this->mBlock being a real block object. Hence you're not actually blocked.

Not sure what the cleanest solution would be. either change relavent methods of user to not look for $this->mBlock, or introduce a new FakeBlock class for cases where the user doesn't have a block in db, but is blocked.
Comment 1 Happy-melon 2012-03-18 17:47:36 UTC
I'd definitely support FakeBlock, probably as an abstract class that can be implemented as SorbsFakeBlock, or TorFakeBlock, etc.  The connection between the new Block stuff and the old User code is still pretty ugly in trunk...
Comment 2 Krinkle 2012-03-19 14:41:46 UTC
r114117 claims this bug is fixed
Comment 3 Andre Klapper 2012-11-04 17:38:54 UTC
*** Bug 34385 has been marked as a duplicate of this bug. ***

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links