Last modified: 2012-03-22 20:13:03 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T37309, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 35309 - formatDuration message missing/inconsistent


Summary:	formatDuration message missing/inconsistent

Status:	RESOLVED FIXED

Product:	MediaWiki
Classification:	Unclassified
Component:	Language converter (Other open bugs)
Version:	unspecified
Hardware:	All All

Importance:	Unprioritized minor (vote)
Target Milestone:	---
Assigned To:	Nobody - You can work on this!

URL:
Whiteboard:
Keywords:	patch, patch-reviewed

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2012-03-18 21:36 UTC by Dan Collins
Modified:	2012-03-22 20:13 UTC (History)
CC List:	5 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
A patch that standardizes as millennia. Spelled correctly, unlike the filename of the patch. (861 bytes, patch) 2012-03-18 21:36 UTC, Dan Collins	Details
Add an attachment (proposed patch, testcase, etc.)

Description Dan Collins 2012-03-18 21:36:37 UTC

Created attachment 10260 [details]
A patch that standardizes as millennia. Spelled correctly, unlike the filename of the patch.

Language::formatDuration expects a message <duration-millennia>. maintenance/language/messages.inc expects a message <duration-millenniums>. MessagesEn.php provides neither. Patch is attached, three phpunit tests fail before the patch, all pass after the patch.

Comment 1 Sumana Harihareswara 2012-03-18 21:39:43 UTC

Thanks for the patch, Dan!

By the way, Dan, we're switching to Git this week; do you already have an account?  https://labsconsole.wikimedia.org/wiki/Help:Access#Access_FAQ That way, in the future, you can just submit a merge request instead of having to do a Bugzilla patch attachment.

Comment 2 Sam Reed (reedy) 2012-03-18 23:22:31 UTC

r114118

Comment 3 Antoine "hashar" Musso (WMF) 2012-03-22 20:10:47 UTC

r114118 reverted in Gerrit so I am reopening this bug.

Comment 4 Antoine "hashar" Musso (WMF) 2012-03-22 20:13:03 UTC

re resolved since this bug was caused by a patch that got reverted as well :-]  Sorry for the mail spam.

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links