Last modified: 2012-03-20 08:58:02 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T37352, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 35352 - Getting zero related data charge warnings on the regular mobile site
Getting zero related data charge warnings on the regular mobile site
Status: RESOLVED FIXED
Product: Wikimedia Mobile
Classification: Unclassified
Generic (Other open bugs)
.5
All All
: Unprioritized normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-03-20 07:32 UTC by Asher Feldman
Modified: 2012-03-20 08:58 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
Only enables zero rated on file page when $renderZeroRatedBanner set (721 bytes, patch)
2012-03-20 08:02 UTC, Jon
Details

Description Asher Feldman 2012-03-20 07:32:43 UTC
When using en.m.wikipedia.org from my iphone, clicking an image takes me to an imageless page with a "Data charges may apply if you continue" banner.

This is only supposed to be shown on zero, and only on select carriers that aren't zero rating images.  This is supposed to be determined by the value of the X-Carrier header which is set by varnish via ip acls but I don't see any use of that header in the deployed or trunk versions of MobileFrontend.
Comment 1 Jon 2012-03-20 08:02:38 UTC
Created attachment 10287 [details]
Only enables zero rated on file page when $renderZeroRatedBanner set
Comment 2 Tomasz Finc 2012-03-20 08:58:02 UTC
Changes checked in and are preilly approved. This has now been deployed to production. 

Issues is resolved minus some old cached file desc pages.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links