Last modified: 2012-06-14 10:03:35 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T37366, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 35366 - lang attribute must be added to Babel elements to enable WebFonts
lang attribute must be added to Babel elements to enable WebFonts
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
Babel (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Robin Pepermans (SPQRobin)
:
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2012-03-20 21:01 UTC by Gerard Meijssen
Modified: 2012-06-14 10:03 UTC (History)
6 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Gerard Meijssen 2012-03-20 21:01:33 UTC 
On systems with WebFonts enabled, Babel extension does not get triggered. Including the lang tag is a div or a span will for instance show the Tibetan script for Dzongkha or Tibetan.
Thanks,
    Gerard
Comment 1 Robin Pepermans (SPQRobin) 2012-03-20 21:04:58 UTC 
This was introduced in r84020 but reverted in r97716.

I support (re-)adding the lang attributes, in most cases this is more correct and it has the advantage of triggering WebFonts.
Comment 2 Siebrand Mazeland 2012-06-12 12:35:58 UTC 
Update assignee and CCs
Comment 3 Robin Pepermans (SPQRobin) 2012-06-13 00:25:59 UTC 
Added in https://gerrit.wikimedia.org/r/#/c/11131/
Comment 4 Amir E. Aharoni 2012-06-13 14:14:04 UTC 
Nikerabbit says in the revert message: "we should not tag language unless we are pretty much certain it is correct". Is this really a problem? If the language is not correct it should just be translated.
Comment 5 Amir E. Aharoni 2012-06-14 10:03:35 UTC 
Merged.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links