Last modified: 2012-08-06 19:25:46 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T37376, the corresponding Phabricator task for complete and up-to-date bug report information.
First Last Prev Next    This bug is not in your last search results.
Bug 35376 - VisualEditor: npm dependencies
VisualEditor: npm dependencies
Status: RESOLVED FIXED
Product: Parsoid
Classification: Unclassified
General (Other open bugs)
unspecified
All All
: Unprioritized enhancement
: ---
Assigned To: Gabriel Wicke
: patch, patch-need-review
Depends on:
Blocks:
  Show dependency tree / graph
 
Reported: 2012-03-21 10:04 UTC by Adam Wight
Modified: 2012-08-06 19:25 UTC (History)
7 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---

Attachments
New file to track npm dependencies (681 bytes, patch)
2012-03-21 10:04 UTC, Adam Wight 		Details
Add an attachment (proposed patch, testcase, etc.)

Description Adam Wight 2012-03-21 10:04:28 UTC 
Created attachment 10299 [details]
New file to track npm dependencies

This patch will make it simpler to install node module dependencies.  When the package.json file exists, running "npm install" with no arguments will create a directory "node_modules" and fetch dependencies.

There are some related improvements to be made, such as editing the Makefile to point NODE_PATH to this directory.  Actually, I don't know what the recommended practice is here--seems like this should be in node's default require path.

My focus was on running the tests, not sure about how to reuse this file for server configuration.
Comment 1 Sumana Harihareswara 2012-03-21 18:54:01 UTC 
Thanks for the patch, Adam! I've added keywords to indicate that this patch awaits code review.
Comment 2 MZMcBride 2012-06-22 20:16:18 UTC 
What's the status of this bug?

And can someone please clarify the bug summary? I have no idea what "npm dependencies" means.
Comment 3 James Forrester 2012-06-22 22:05:29 UTC 
Mass-moving items into VisualEditor product
Comment 4 James Forrester 2012-06-22 22:19:56 UTC 
Assuming this is for Gabriel
Comment 5 Gabriel Wicke 2012-06-23 17:06:39 UTC 
Merged a while ago.
Comment 6 James Forrester 2012-08-06 19:25:46 UTC 
Mass-moving bugs into the new 'Parsoid' product.
Note You need to log in before you can comment on or make changes to this bug.
First Last Prev Next    This bug is not in your last search results.

Navigation
Links