Last modified: 2012-08-06 19:25:37 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T37377, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 35377 - VisualEditor: wrap parser output callback
VisualEditor: wrap parser output callback
Status: RESOLVED FIXED
Product: Parsoid
Classification: Unclassified
General (Other open bugs)
unspecified
All All
: Low normal
: ---
Assigned To: Gabriel Wicke
: patch, patch-need-review
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-03-21 10:15 UTC by Adam Wight
Modified: 2012-08-06 19:25 UTC (History)
9 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
patch (1.10 KB, patch)
2012-03-21 10:15 UTC, Adam Wight
Details

Description Adam Wight 2012-03-21 10:15:18 UTC
Created attachment 10300 [details]
patch

Totally trivial static function to abstract out __parseArgs[2] and explain.  It's possible that we want the flush() functionality to work differently in the future.
Comment 1 Sumana Harihareswara 2012-03-21 18:53:18 UTC
Thanks for the patch! Added keywords to ask for code review.
Comment 2 Sumana Harihareswara 2012-03-22 03:02:32 UTC
By the way, Adam, you can get a Gerrit account if you want and suggest changes to be merged directly into our Git repository: https://www.mediawiki.org/wiki/Project:Labsconsole_account & https://www.mediawiki.org/wiki/Git/Workflow#Easier_submission_of_code have more information.
Comment 3 MZMcBride 2012-06-22 19:59:02 UTC
What's the status of this bug? And does it actually relate to the VisualEditor extension?
Comment 4 James Forrester 2012-06-22 22:05:19 UTC
Mass-moving items into VisualEditor product
Comment 5 James Forrester 2012-06-22 22:21:41 UTC
Gabriel - this still current?
Comment 6 Gabriel Wicke 2012-06-23 18:39:33 UTC
Just noticed that this was assigned to my old (now reactivated with wikimedia address) bugzilla account.

It is still current, and still relates to VE since Parsoid is currently treated as a submodule of VE in Bugzilla. We should perhaps create a separate product for it so that we can set up our own set of default assignees etc.
Comment 7 Gabriel Wicke 2012-06-30 08:40:49 UTC
Fixed in commit 1736e52bfb6c6b459b571cd8a8f26c7ee6d84da7. Thanks for your patch, Adam!
Comment 8 James Forrester 2012-08-06 19:25:37 UTC
Mass-moving bugs into the new 'Parsoid' product.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links