Last modified: 2012-06-22 22:22:36 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T37392, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 35392 - VisualEditor: behavior switches are saved in parser environment
VisualEditor: behavior switches are saved in parser environment
Status: RESOLVED WONTFIX
Product: VisualEditor
Classification: Unclassified
General (Other open bugs)
unspecified
All All
: Low normal
: ---
Assigned To: Nobody - You can work on this!
: patch, patch-need-review
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-03-21 19:26 UTC by Adam Wight
Modified: 2012-06-22 22:22 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
parser patch to stub signature wikitext (1.06 KB, patch)
2012-03-21 19:26 UTC, Adam Wight
Details
parser grammar stub for behavior switch magic words (1.15 KB, patch)
2012-03-21 19:27 UTC, Adam Wight
Details

Description Adam Wight 2012-03-21 19:26:29 UTC
Created attachment 10308 [details]
parser patch to stub signature wikitext

Just learning about the parser--these patches will match the __NOTOC__ etc. layout behavior switch keywords, and signature and timestamp strings.

I'm not so confident about my decisions where to put these grammars.

The behavior switch keywords should probably turn into tokens which send control commands to set state in the sync23 stage.

The signature doesn't have access to the current username.  The timestamp has no locale or user timezone functionality.
Comment 1 Adam Wight 2012-03-21 19:27:23 UTC
Created attachment 10309 [details]
parser grammar stub for behavior switch magic words
Comment 2 Adam Wight 2012-04-01 02:34:27 UTC
Patches have been deprecated in favor of https://gerrit.wikimedia.org/r/4050

I've abandoned the signature/timestamp patch, agreeing with Brion that,
> These sorts of things really should be happening *in* the editor, rather
> than in the parser. We only have to put ~~~~ in because the original editor
> was too primitive to have a nice "insert signature" live function. So I
> think it's worth really rethinking how these things get done for the new
> paradigm. :)
Comment 3 James Forrester 2012-06-22 22:05:41 UTC
Mass-moving items into VisualEditor product
Comment 4 James Forrester 2012-06-22 22:22:36 UTC
Seems to be a NOTDONE given Adam's comment. :-)

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links