Last modified: 2012-03-29 20:11:14 UTC
"I would prefer that you didn't submit this" is too personal and negative. One of the goals of the switch to Git and Gerrit is to make MediaWiki development more welcoming to newbies by making sending patches easier. This message does exactly the opposite - it essentially tells the person who wrote the patch: "Your work is bad, you wasted your time and my time and I don't like you". A better wording would be something like this: "This commit must be fixed before merging". Even SVN's "FIXME" is much better than "I would prefer that you didn't submit this", because it's immediately clear that it's a technical and not a personal thing. I also commented about this in the Gerrit bug tracker [1], but if it's possible to fix it locally, it should be done ASAP. [1] http://code.google.com/p/gerrit/issues/detail?id=1241
I *believe* we can do this outselves: mysql> select * from approval_category_values; +-------------------------------------------------+-------------+-------+ | name | category_id | value | +-------------------------------------------------+-------------+-------+ | Verified | VRIF | 1 | | No score | VRIF | 0 | | Fails | VRIF | -1 | | Looks good to me, approved | CRVW | 2 | | Looks good to me, but someone else must approve | CRVW | 1 | | No score | CRVW | 0 | | I would prefer that you didn't submit this | CRVW | -1 | | Do not submit | CRVW | -2 | +-------------------------------------------------+-------------+-------+ 8 rows in set (0.00 sec)
Hmm, tried setting this on the test gerrit install but it didn't apply. I'm wondering if gerrit needs a restart. Also, I don't think it'll change for any comments already submitted.
Yes, it does need a restart. No, it doesn't change old comments so we should do this sooner rather than later.
Did a bit of bikeshedding on wikitech-l about this. Consensus seems to be for "There is a problem with this patchset, please improve." I'll look at applying this change and getting gerrit restarted.
We ended up settling on "There's a problem with this change, please improve" due to varchar(50). Anyway, this is now live.
