Last modified: 2012-04-18 16:05:30 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T37414, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 35414 - Debug parameters don't work as expected
Debug parameters don't work as expected
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
ArticleFeedbackv5 (Other open bugs)
unspecified
All All
: Low normal (vote)
: ---
Assigned To: Yoni Shostak
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-03-22 19:29 UTC by Reha Sterbin
Modified: 2012-04-18 16:05 UTC (History)
1 user (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Reha Sterbin 2012-03-22 19:29:32 UTC
[From Fabrice, 3/21]

Debug parameters don't work as expected:

* (high priority) Cannot use a direct link to force one option to display in debug mode, as so:
http://en.wikipedia.org/wiki/Golden-crowned_Sparrow?bucket=1&debug=true&aftv5_link=E

* However, if you set debug to 'false', you can cause it to do what it should do:
http://en.wikipedia.org/wiki/Golden-crowned_Sparrow?bucket=1&debug=false&aftv5_link=E

* It's also not clear how to force the *actual* bucketing: it looks like the "bucket" parameter is used to switch to a different design but it doesn't rebucket me in a different condition: that's not what I would expect.

* It is still possible to access the old feedback forms, either based on a 'previous bucket' cookie or by entering a link such as this one:
http://en.wikipedia.org/wiki/Golden-crowned_Sparrow?bucket=2&debug=false&aftv5_link=E
Comment 1 Reha Sterbin 2012-03-22 19:36:59 UTC
This appears to have been a caching issue.  I'm able to use the aftv5_link parameter with debug=true to select link options.

The "bucket" parameter is a holdover from the early days of AFTv5, when the only thing being bucketed was form display options -- the form options are named "bucket" throughout the code.  While that's not ideal, the risk involved with a manual change on this sort of scale is quite high, and the benefit is very small.

An alternative would be for me to rename only the url parameter, or to remove it entirely.

See https://www.mediawiki.org/wiki/Article_feedback/Version_5/Technical_Design#Debug_state_and_query_string_options for how the url parameters are meant to work.
Comment 2 Reha Sterbin 2012-03-22 19:40:27 UTC
Note also that when using the url parameters, you have access to all of the form options that are in the javascript, regardless of what is being shown to normal users.

Given that Option 1 has been chosen moving forward, I think it's probably time to remove all of the other options from the javascript -- it will shrink the file significantly, which is always good for load time.
Comment 3 Reha Sterbin 2012-03-22 19:40:57 UTC
Reassigning to Fabrice for his input.
Comment 4 Reha Sterbin 2012-03-22 19:56:46 UTC
Punting back to Yoni (protocol!)

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links