Last modified: 2012-03-28 14:48:23 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T37547, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 35547 - LQT comments are not displayed after editing them
LQT comments are not displayed after editing them
Status: RESOLVED FIXED
Product: MediaWiki extensions
Classification: Unclassified
LiquidThreads (Other open bugs)
unspecified
All All
: Normal normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-03-28 00:27 UTC by Helder
Modified: 2012-03-28 14:48 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Helder 2012-03-28 00:27:08 UTC
After doing this edit:
https://www.mediawiki.org/w/index.php?title=Thread%3AExtension_talk%3AGeoGebra%2FMoving_to_code_repository%2Freply&diff=516577&oldid=516576
I got the following error on Google Chrome 17.0.963.83:
----
Uncaught TypeError: Cannot read property 'content' of undefined

window.liquidThreads.doReloadThread load.php:18
jQuery.Callbacks.fire load.php:14
jQuery.Callbacks.self.fireWith load.php:15
done load.php:112
jQuery.ajaxTransport.send.callback
----

When the error happened the following line of code was selected in the [Script] tab:

'<div class="mw-ajax-loader"/>');var header=$j('#lqt-header-'+threadId);thread.prepend(loader);var apiReq={'action':'query','list':'threads','thid':threadId,'format':'json','thrender':1};$j.get(mw.util.wikiScript('api'),apiReq,function(data){var html=data.query.threads[threadId].content;var newContent=$j(html);thread.empty();thread.hide();header.empty();header.hide();var newThread=newContent.filter('div.lqt_thread');var newThreadContent=newThread.contents();thread.append(newThreadContent);thread.attr('class',newThread.attr('class'));thread.find('.lqt-post-wrapper').each(function(){liquidThreads.setupThread($j(this));});header.fadeIn();thread.fadeIn();var targetOffset=$j(thread).offset().top;$j('html,body').animate({scrollTop:targetOffset},'slow');},'json');},'setupThread':function(threadContainer){var prefixLength="lqt_thread_id_".length;$parentWrapper=$j(threadContainer).closest('.lqt-thread-wrapper').parent().closest('.lqt-thread-wrapper');if($parentWrapper.next('.lqt-thread-wrapper'
Uncaught TypeError: Cannot read property 'content' of undefined
Comment 1 Helder 2012-03-28 00:32:59 UTC
After doing another test in debug mode,
https://www.mediawiki.org/w/index.php?title=Thread%3AExtension_talk%3AGeoGebra%2FMoving_to_code_repository%2Freply&diff=516581&oldid=516577
I found the exact line of
https://bits.wikimedia.org/w/extensions-1.19/LiquidThreads/lqt.js
where the error is happening. It is the following:
----
var html = data.query.threads[threadId].content;
----
Comment 2 Mark A. Hershberger 2012-03-28 14:48:23 UTC
https://gerrit.wikimedia.org/r/3860

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links