Last modified: 2013-06-08 01:05:48 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T37565, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 35565 - [Regression] Special:Log/patrol doesn't show "(automatic)" for autopatrols anymore
[Regression] Special:Log/patrol doesn't show "(automatic)" for autopatrols an...
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Logging (Other open bugs)
1.19
All All
: Normal major (vote)
: 1.19.0 release
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-03-28 16:14 UTC by Krinkle
Modified: 2013-06-08 01:05 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Krinkle 2012-03-28 16:14:14 UTC
Compare for example

* http://finanpedia.nl/wiki/Speciaal:Logboeken/patrol?uselang=en
* https://nl.wikipedia.org/w/index.php?title=Speciaal:Logboeken&type=patrol&user=Krinkle&uselang=en

Although autopatrol isn't a distinct log_action/log_type, they are detectable when iterating over rows with the log_params/comment information. Up until 1.19 this was also reported in the log, but now is no longer.

This is affecting patrollers on wikis with rcpatrol.
Comment 1 Niklas Laxström 2012-03-28 20:02:23 UTC
It should still work, it has just been reworded:
'logentry-patrol-patrol'              => '$1 marked revision $4 of page $3 patrolled',
'logentry-patrol-patrol-auto'         => '$1 automatically marked revision $4 of page $3 patrolled'
Comment 2 Trijnstel 2012-03-28 20:36:09 UTC
It's still not fixed, see for example https://nl.wikipedia.org/w/index.php?title=Speciaal:Logboeken&type=patrol&user=Trijnstel&uselang=en
Comment 3 Max Semenik 2012-03-28 23:02:01 UTC
Fixed in https://gerrit.wikimedia.org/r/3895
Comment 4 Trijnstel 2012-03-29 12:40:58 UTC
Sorry to say, but no, it's still not fixed. Take for example the patrol log of MoiraMoira (another Dutch admin): https://nl.wikipedia.org/w/index.php?title=Speciaal:Logboeken&type=patrol&user=MoiraMoira&uselang=en - I don't see the word "automatic" anywhere...
Comment 5 Max Semenik 2012-03-29 13:31:46 UTC
When things are fixed in source control, they don't magically get deployed to cluter, wait a little.
Comment 6 Robert Morley 2013-06-07 23:07:20 UTC
As of 1.19.3, this still hasn't been incorporated.
Comment 7 Krinkle 2013-06-08 00:19:20 UTC
(In reply to comment #6)
> As of 1.19.3, this still hasn't been incorporated.

This bug was fixed in March 2012 and first released in v1.20.0. It was deployed in wmf/1.20wmf1 

It will not be back ported to v1.19 at this time since v1.19 is on legacy support and this probably won't be enough for a follow-up release (v1.21 has already been released, v1.22 is under development).


(In reply to comment #4)
> Sorry to say, but no, it's still not fixed. Take for example the patrol log
> of
> MoiraMoira (another Dutch admin):
> https://nl.wikipedia.org/w/index.php?title=Speciaal:
> Logboeken&type=patrol&user=MoiraMoira&uselang=en
> - I don't see the word "automatic" anywhere...



18:20, 7 June 2013 MoiraMoira (..)
  automatically marked revision 37912636 of page .. patrolled
18:17, 7 June 2013 MoiraMoira (..)
  automatically marked revision 37912623 of page .. patrolled
18:16, 7 June 2013 MoiraMoira (..)
  automatically marked revision 37912617 of page .. patrolled
15:15, 7 June 2013 MoiraMoira (..)
  marked revision 37911385 of page .. patrolled

It does now :)
Comment 8 Robert Morley 2013-06-08 01:05:48 UTC
For any 1.19 users out there, I've just finished porting the changes from the link in comment 3 and they work fine.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links