Last modified: 2014-05-25 09:19:33 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T37578, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 35578 - Some IPs hidden without any log or apparent reason on frwiki
Some IPs hidden without any log or apparent reason on frwiki
Status: RESOLVED FIXED
Product: Wikimedia
Classification: Unclassified
General/Unknown (Other open bugs)
unspecified
All All
: Lowest major with 4 votes (vote)
: ---
Assigned To: orlodrim
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-03-29 07:14 UTC by Snowolf
Modified: 2014-05-25 09:19 UTC (History)
16 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Snowolf 2012-03-29 07:14:37 UTC
https://fr.wikipedia.org/w/index.php?title=Aide%3ALiens_internes&action=history&year=&month=-1&tagfilter=&deleted=1 The various IPs are getting hidden in a rather weird way, with no entries into the log. They are not blocked locally, or at least some aren't, and so there isn't any hideuser in place nor there is a global oversight (as that works only on accounts). It seems rather misterious how all these IPs, dating back to 2009, on this specific page get this treatment (which is suppression of the username/IP from those edits -- it can be manually undone by unticking the boxes, but there's no log of why they were hidden anywhere that we could find).
Comment 1 orlodrim 2012-03-29 07:35:36 UTC
Indeed, this is a global problem on frwiki: all IP contributions made more than a few hours ago (before 2012-03-29 2:50 UTC at this time) appear as is they were hidden by oversight in all histories and lists of contributions. They are still visible in the list of recent changes, however.
Comment 2 Dan Collins 2012-03-29 07:43:12 UTC
Confirmed. Appears to be fr.wiki only, see for example fr.wikt OK at [1] and en.wp appears unaffected. Marking as a wikimedia issue for now and increasing priority.

[1]: http://fr.wiktionary.org/w/index.php?title=naviguer&action=history
Comment 3 Snowolf 2012-03-29 22:51:48 UTC
Interestingly enough, some IPs do not get hidden, see https://fr.wikipedia.org/w/index.php?title=Aide:Liens_internes&action=history (the 188.241.127.40 was unsuppressed by me to test stuff, but the other edits after seem not suppressed, this is most peculiar)
Comment 4 Tim Starling 2012-03-30 00:05:47 UTC
Apparently there was a bug in global suppression that caused this to happen when Snowolf suppressed a certain user via Special:CentralAuth on meta. Aaron has deployed a temporary fix and is working on a cleanup script at the moment.
Comment 5 Tim Starling 2012-03-30 06:08:15 UTC
Actually the account was suppressed via ApiBlock, not CentralAuth. I was just misled by the block summary. ApiBlock calls  SpecialBlock::processForm(), which since r83810 has not properly validated its parameters. It doesn't notice when the user does not exist, blindly passing it through to Block::setTarget() and RevisionDeleteUser::suppressUserName(). 

The ipblocks row had a non-zero ipb_by which is not possible with CentralAuth. So I cross-referenced the event time with the logs, and sure enough, there was an api.php post to frwiki at the time in question.
Comment 6 Tim Starling 2012-03-30 07:06:01 UTC
I'm running a cleanup script.
Comment 7 Tim Starling 2012-03-30 09:08:17 UTC
We could have got the old rev_deleted values out of a snapshot if this was escalated early enough, but they only last 16 hours and it's been 31.
Comment 8 Jérémie Roquet 2012-03-30 13:15:50 UTC
I don't know what the cleanup script does exactly (replay the suppress log, maybe?), nor if it has already finished running, so I apologize in advance if my comment is irrelevant.

It seems to me that most of the hidden IPs are back, except when the visibility of a revision had actually been changed. For example in ¹ or ², some revisions were /deleted/ (only for the content) by a sysop, but they now appear as /suppressed/ (for both the content and the IP) as if they had been oversighted.

Best regards,

¹ https://fr.wikipedia.org/w/index.php?title=%C3%89pisodes_de_Hollywood_Girls_:_Une_nouvelle_vie_en_Californie&action=history
² https://fr.wikipedia.org/w/index.php?title=F%C3%A9d%C3%A9ration_nationale_des_associations_d%27accueil_et_de_r%C3%A9insertion_sociale&action=history
Comment 9 Tim Starling 2012-04-02 02:11:03 UTC
Revisions by anonymous users which formerly had their rev_deleted flags set to DELETED_USER|DELETED_RESTRICTED (i.e. hidden user and suppressed) were temporarily visible. I've now searched the suppress logs and determined that 18 such revisions were given those flags at some point in the past, so I re-hid them with SQL. 

The remaining data corruption that I'm aware of is:

* Revisions by anonymous users which previously had one or the other of the deleted flags (hidden user or suppressed) now have both.
* Revisions by anonymous users which previously had both hidden user and suppressed, but were subsequently unhidden (rev_deleted=0), will now be rehidden. I don't know if there are any such revisions.

If the remaining data corruption has little impact then I'd be happy to leave it as is. The flags can always be fixed by on-wiki actions if there is a reason to do that in some specific case.
Comment 10 Mark A. Hershberger 2012-04-02 15:55:19 UTC
Lowering priority since it looks like the emergency is over.  I'll leave this to someone else to close.
Comment 11 Jérémie Roquet 2012-04-05 18:08:01 UTC
Hi,

Thanks for you help.

> * Revisions by anonymous users which previously had one or the other of the
deleted flags (hidden user or suppressed) now have both.

I don't think this is a major issue. I suppose anonymous users are hidden for privacy reasons, so I doubt the suppressed flag could bother the sysops; and suppressed revisions being visible only with the oversight right, the user is visible too.

> * Revisions by anonymous users which previously had both hidden user and
suppressed, but were subsequently unhidden (rev_deleted=0), will now be
rehidden. I don't know if there are any such revisions.

If any, that shouldn't be a big issue either.

Unfortunately, there is at least one other remaining corruption which is much more annoying: revisions which have had their rev_deleted flags set to DELETED_TEXT (ie. only the text has been deleted, and still visible to sysops) now have it set to DELETED_TEXT | DELETED_USER | DELETED_RESTRICTED . This prevents both regular users and sysops from knowing that a given anonymous user's edits were deleted. For example, if you look at ¹ without the oversight rights, you only see 9 edits, each of which looks legit. But if you have oversight rights, you can see 9 more edits which were deleted (*not* suppressed) because of blatant copyright violation. These revisions should be visible to sysops (user and text) and to regular users (user only) so that they can fight recurring copyright violation and identify long-term copyright violators and other vandals and sockpuppets (among other things). Other examples include the two links I have posted before (² and ³), where neither the regular users nor the sysops can check who is responsible of the edits that have been deleted nor if the deletion was justified.

I'd be happy to help to fix the remaining issues if I can. Maybe by proposing relevant sql queries?

Best regards,

¹ https://fr.wikipedia.org/wiki/Sp%C3%A9cial:Contributions/82.230.44.141
² https://fr.wikipedia.org/w/index.php?title=%C3%89pisodes_de_Hollywood_Girls_:_Une_nouvelle_vie_en_Californie&action=history
³ https://fr.wikipedia.org/w/index.php?title=F%C3%A9d%C3%A9ration_nationale_des_associations_d%27accueil_et_de_r%C3%A9insertion_sociale&action=history
Comment 12 matanya 2012-07-22 19:45:05 UTC
still seems to be hidden per links above.
Comment 13 Snowolf 2012-11-03 14:39:43 UTC
Any update on this? I still see the issues jroquet raised above.
Comment 14 Andre Klapper 2012-11-06 18:42:19 UTC
The already existing data corruption, or some new problems with this?
Comment 15 Jérémie Roquet 2012-11-06 18:51:25 UTC
There is no new problem, AFAIK, but the issue described above are not yet resolved.

Best regards
Comment 16 Jérémie Roquet 2012-12-12 00:04:26 UTC
Dear all,

Orlodrim and myself are currently studying the possibility of fixing the remaining corruptions locally using a bot. I'm confident about our ability to do this without damage, but this will flood the oversight logs.

Best regards an thanks again for your help.
Comment 17 This, that and the other (TTO) 2013-10-13 08:57:15 UTC
Does this bug report still need to be open?
Comment 18 Andre Klapper 2014-03-19 16:06:03 UTC
(In reply to Jérémie Roquet from comment #16)
> Orlodrim and myself are currently studying the possibility of fixing the
> remaining corruptions locally using a bot. I'm confident about our ability
> to do this without damage, but this will flood the oversight logs.

Any news? Is anybody actually still interested in fixing this (it's been two years now)?
Comment 19 John F. Lewis 2014-03-27 22:00:09 UTC
Per https://fr.wikipedia.org/wiki/Wikip%C3%A9dia:Masqueur_de_modifications/Renouvellement#Nomination_d.27un_masqueur_.C3.A0_titre_provisoire - The French Wikipedia ArbCom have resolved to promote Orlodrim to Oversighter for the purpose of this bug.

Assigned said user assuming they are working on it as it seems so from the request filed as SRP.
Comment 20 orlodrim 2014-03-28 18:17:00 UTC
I confirm that I will work on this bug, following the approach previously explained by Arkanosis. This will generate about 5600 events in the suppression log.
Comment 21 orlodrim 2014-05-25 09:19:33 UTC
This is now fixed. I changed the visibility of 37238 revisions in 5234 pages.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links