Last modified: 2012-03-29 14:38:58 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T37583, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 35583 - GitInfo::isSHA1 returns true for non-sha1 values


Summary:	GitInfo::isSHA1 returns true for non-sha1 values

Status:	RESOLVED FIXED

Product:	MediaWiki
Classification:	Unclassified
Component:	General/Unknown (Other open bugs)
Version:	1.20.x
Hardware:	All All

Importance:	Unprioritized trivial (vote)
Target Milestone:	---
Assigned To:	Nobody - You can work on this!

URL:
Whiteboard:
Keywords:	patch, patch-reviewed

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2012-03-29 14:36 UTC by Alexis
Modified:	2012-03-29 14:38 UTC (History)
CC List:	0 users

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
patch hopefully solving the problem (523 bytes, patch) 2012-03-29 14:36 UTC, Alexis	Details
Add an attachment (proposed patch, testcase, etc.)

Description Alexis 2012-03-29 14:36:16 UTC

Created attachment 10350 [details]
patch hopefully solving the problem

SHA1 are hex values, bur regex checks for [0-9A-Z] instead of [0-9A-F]

Proposed patch is in attachment.

Comment 1 Sam Reed (reedy) 2012-03-29 14:38:58 UTC

Thanks, https://gerrit.wikimedia.org/r/#change,3914

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links