Last modified: 2012-12-19 12:27:28 UTC
see title
For reference: https://www.mediawiki.org/wiki/Git/Workflow#How_to_comment_on.2C_review.2C_and_merge_code_in_Gerrit The phrase "Cover message" is foreign and strange; "comment" would be better and would fit in with our usual usage of "comment".
(In reply to comment #2) > For reference: > https://www.mediawiki.org/wiki/Git/Workflow#How_to_comment_on.2C_review.2C_and_merge_code_in_Gerrit > > The phrase "Cover message" is foreign and strange; "comment" would be better > and would fit in with our usual usage of "comment". It's meant to be a "Cover message" on top of the individual inline comments you left...so I at least *see* where they're coming from here. Haven't looked at how trivial/possible it is to tweak UI wording yet.
That is actually a cover message, not a place for people to randomly comment about the patch set. Comments should be about the code, and thus done inline in the diff. Gerrit is build using Google Web Toolkit, I.E the application is technically a Java application. To change the text, we would have to change a Java property in : gerrit-gwtui/src/main/java/com/google/gerrit/client/changes/ChangeConstants.properties Then recompile Gerrit and install the resulting .war. So any customization requires us to actually fork and maintain our own copy of Gerrit. I am not sure it is worth it just to tweak a text message. The issue should be reported upstream for discussion and this bug report closed.
The ChangeConstants.properties file I talked about has content such as: buttonReview = Review buttonPublishCommentsSend = Publish Comments buttonPublishSubmitSend = Publish and Submit buttonPublishCommentsCancel = Cancel headingCoverMessage = Cover Message: headingPatchComments = Patch Comments: On second thought, maybe that property file can be configured / provided along the .war without requiring a fork / custom build.
(In reply to comment #5) > The ChangeConstants.properties file I talked about has content such as: > > buttonReview = Review > buttonPublishCommentsSend = Publish Comments > buttonPublishSubmitSend = Publish and Submit > buttonPublishCommentsCancel = Cancel > headingCoverMessage = Cover Message: > headingPatchComments = Patch Comments: > > > On second thought, maybe that property file can be configured / provided along > the .war without requiring a fork / custom build. Making this customizable without forking the .war is worth reporting upstream.
Reported and tagged +upstream. Marking LATER pending some movement there.
[Removing RESOLVED LATER as discussed in http://lists.wikimedia.org/pipermail/wikitech-l/2012-November/064240.html . Reopening and setting priority to "Lowest". For future reference, please use either RESOLVED WONTFIX (for issues that will not be fixed), or simply set lowest priority. Thanks a lot!]
Unless upstream moves on this (which I doubt they will), this isn't going to happen. Marking WONTFIX.