Last modified: 2012-04-16 09:16:02 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T37601, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 35601 - Watchlist doesn't show or count pages not in the main namespace when deleting them from the watchlist
Watchlist doesn't show or count pages not in the main namespace when deleting...
Status: RESOLVED FIXED
Product: MediaWiki
Classification: Unclassified
Watchlist (Other open bugs)
unspecified
All All
: High minor (vote)
: ---
Assigned To: Nobody - You can work on this!
: patch, patch-need-review
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-03-30 04:51 UTC by Ankit Maity
Modified: 2012-04-16 09:16 UTC (History)
3 users (show)

See Also:
Web browser: Google Chrome
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments
possible patch (983 bytes, patch)
2012-04-07 04:51 UTC, Aaron Pramana
Details

Description Ankit Maity 2012-03-30 04:51:18 UTC
On removing 8-9 titles from my watchlist, I got the following message:

6 titles were removed from your watchlist:
Andrew Kenyon-Smith (talk)
Ben Knapp (talk)
Jakob Ullmann (talk)
Ji Hyunwoo (talk)
Phil Murray (talk)
Top Dogg (talk)

which should be:

8 (or 9) titles were removed from your watchlist:
Andrew Kenyon-Smith (talk)
Ben Knapp (talk)
Jakob Ullmann (talk)
Ji Hyunwoo (talk)
Phil Murray (talk)
Top Dogg (talk)
<whatever> (talk)
<whatever> (talk)
<whatever> (talk)

I have been experiencing this from a long time. But they were removed all right.
Comment 1 Ankit Maity 2012-03-30 04:52:08 UTC
*** This bug has been confirmed by popular vote. ***
Comment 2 Mark A. Hershberger 2012-04-02 16:19:13 UTC
Confirmed.  Looks like it isn't counting pages that are not in the main namespace.
Comment 3 Ankit Maity 2012-04-03 04:19:25 UTC
Yah! You are right.
Comment 4 Aaron Pramana 2012-04-07 04:51:22 UTC
Created attachment 10387 [details]
possible patch

This should do the trick - feedback is appreciated as I'm still new to MediaWiki development.
Comment 5 Sumana Harihareswara 2012-04-09 02:43:04 UTC
Adding the "patch" and "need-review" keywords so experienced developers know that this patch awaits review.

Also, Aaron, you can easily get developer access https://www.mediawiki.org/wiki/Developer_access and then you can submit this as a git commit right into our source control system: https://www.mediawiki.org/wiki/Git/Workflow

Thanks for the patch!
Comment 6 Mark A. Hershberger 2012-04-09 15:12:49 UTC
https://gerrit.wikimedia.org/r/4561

Updated your patch
Comment 7 Brion Vibber 2012-04-09 17:06:30 UTC
Reopening as fix not merged yet. Current patch on gerrit looks a bit overkill, it only needs to use array_merge() in one line I think.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links