Last modified: 2013-10-23 18:17:02 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T37693, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 35693 - ApiQueryImageInfo.php should wfSuppressErrors() before trying to unserialize


Summary:	ApiQueryImageInfo.php should wfSuppressErrors() before trying to unserialize

Status:	RESOLVED FIXED

Product:	MediaWiki
Classification:	Unclassified
Component:	API (Other open bugs)
Version:	1.18.x
Hardware:	All All

Importance:	Normal normal (vote)
Target Milestone:	---
Assigned To:	Nobody - You can work on this!

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2012-04-04 09:34 UTC by Till Kraemer
Modified:	2013-10-23 18:17 UTC (History)
CC List:	7 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Till Kraemer 2012-04-04 09:34:29 UTC

Hi, 

my error_log is flooded with the following:

[error] PHP Notice: unserialize() [<a href='function.unserialize'>function.unserialize</a>]: Error at offset 0 of 1 bytes in /path/to/pool/wiki/includes/api/ApiQueryImageInfo.php on line 382.

My software: MediaWiki 1.18.2, PHP 5.2.17 (apache), MySQL 5.1.54-log, OpenBSD 4.9.

I'm running 9 language wikis and one pool wiki and the error appears on the pool wiki.

Any suggestions are more than appreciated!

Thanks and cheers,

Till

Comment 1 Bawolff (Brian Wolff) 2012-04-04 13:50:28 UTC

Technical version:

Api should be doing wfSuppressErrors before trying to blindly unserialize, and/or possibly passing through to the relavent media handler's isMetadataValid method first.

Comment 2 Till Kraemer 2012-05-09 12:12:35 UTC

Hi,

I just upgraded to MediaWiki 1.19.0 and I still have that error, except now it's on line 376 (yay!):

[error] PHP Notice:  unserialize() [<a href='function.unserialize'>function.unserialize</a>]: Error at offset 0 of
 1 bytes in /path/to/pool/wiki/includes/api/ApiQueryImageInfo.php on line 376.

Any ideas how to fix this?

Thanks + cheers,

Till

Comment 3 Bryan Tong Minh 2012-09-20 18:39:43 UTC

I7c9649b5

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links