Last modified: 2013-08-19 17:57:49 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T37703, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 35703 - Html presentation different between found results and error msg
Html presentation different between found results and error msg
Status: REOPENED
Product: MediaWiki extensions
Classification: Unclassified
DynamicPageList (Other open bugs)
unspecified
All All
: Low minor (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-04-04 18:27 UTC by Amgine
Modified: 2013-08-19 17:57 UTC (History)
2 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Amgine 2012-04-04 18:27:48 UTC
Html output of method=none has a leading <br />, while the output of the 'Error:No results!' does not.

Example:

http://wiki.occupy.net/index.php?title=OccupyNet:Sandbox&diff=prev&oldid=7745
http://wiki.occupy.net/index.php?title=OccupyNet:Sandbox&diff=prev&oldid=7746
Comment 1 Amgine 2012-04-04 18:30:27 UTC
(may not be a dpl bug, but meh.)
Comment 2 Bawolff (Brian Wolff) 2012-04-04 18:45:37 UTC
That's kind of odd. I think we should get rid of the leading <br/> rather than adding one to the error message.

Check to see if you remove the newline between the <td> and the <dynamicpagelist> if that kills the br. (Could just be the double newline in a row causes parser to insert br. Should perhaps still do something about that, but less of an issue if there is such an easy work around)


(As an aside, those error messages are customizable, so you could add a br manually if you need to)
Comment 3 Amgine 2012-04-04 21:11:27 UTC
(In reply to comment #2)
> That's kind of odd. I think we should get rid of the leading <br/> rather than
> adding one to the error message.
> 
> Check to see if you remove the newline between the <td> and the
> <dynamicpagelist> if that kills the br. (Could just be the double newline in a
> row causes parser to insert br. Should perhaps still do something about that,
> but less of an issue if there is such an easy work around)
> 
> 
> (As an aside, those error messages are customizable, so you could add a br
> manually if you need to)


Yep, removing the newline kills the br. Still weird, but not the extension's behavior?

Yah, I knew the error message was customizable. Too lazy.
Comment 4 Bawolff (Brian Wolff) 2012-04-04 21:36:25 UTC
>but not the extension's
>behavior?

Sort of the extensions fault. What happens is: method=none triggers $startList = '';. Later on we have $output = $startList . "\n";. If there is a newline preceeding the dpl, that results in two new lines in a row. Parser sees two newlines in a row, and interprets it as a <br/>. Extension could be changed to not output that newline at begining and behaviour would go away (or it could be changed to disable that part of parsing on its output and the issue would go away, but that might have unintended consequences)

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links