Last modified: 2012-04-05 18:09:54 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T37728, the corresponding Phabricator task for complete and up-to-date bug report information.

Bug 35728 - Git Revision should be linked on Special:Version


Summary:	Git Revision should be linked on Special:Version

Status:	RESOLVED FIXED

Product:	MediaWiki
Classification:	Unclassified
Component:	Special pages (Other open bugs)
Version:	unspecified
Hardware:	All All

Importance:	Unprioritized minor (vote)
Target Milestone:	---
Assigned To:	Nobody - You can work on this!

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2012-04-05 14:57 UTC by Sam Reed (reedy)
Modified:	2012-04-05 18:09 UTC (History)
CC List:	3 users (show)

See Also:
Web browser:	---
Mobile Platform:	---
Assignee Huggle Beta Tester:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Sam Reed (reedy) 2012-04-05 14:57:49 UTC

We do it for SVN, but not for git

MediaWiki	1.20alpha (7727f66)

MediaWiki	1.19wmf1 (r114429)

Comment 1 Chad H. 2012-04-05 15:15:30 UTC

Should be trivial. For core, just link to

https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/core.git;h={$shortSha1}

For extensions, you can link to:

https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/extensions/{$extName}.git;h={$shortSha1}

Comment 2 Platonides 2012-04-05 15:22:52 UTC

That wouldn't be much useful for third-party wikis using a patched repository. How could they link to the corresponding upstream version?

Comment 3 Chad H. 2012-04-05 15:26:23 UTC

(In reply to comment #2)
> That wouldn't be much useful for third-party wikis using a patched repository.
> How could they link to the corresponding upstream version?

Subclass Special:Version and add to $viewvcUrls. We'd presumably do something similar here with $gitwebUrls.

Comment 4 Alexandre Emsenhuber [IAlex] 2012-04-05 16:26:21 UTC

Fixed pending review in Gerrit change #4335.

Comment 5 Brion Vibber 2012-04-05 18:09:54 UTC

merged in 9afc1eff1c396a4d0273d2226e316cba2fb44ab0

Wikimedia Bugzilla is closed!

Search

Personal tools

Navigation

Links