Last modified: 2013-04-04 21:28:24 UTC

Wikimedia Bugzilla is closed!

Wikimedia migrated from Bugzilla to Phabricator. Bug reports are handled in Wikimedia Phabricator.
This static website is read-only and for historical purposes. It is not possible to log in and except for displaying bug reports and their history, links might be broken. See T37794, the corresponding Phabricator task for complete and up-to-date bug report information.
Bug 35794 - Remove accurate status of FlaggedRevs on MediaWiki.org
Remove accurate status of FlaggedRevs on MediaWiki.org
Status: RESOLVED INVALID
Product: Wikimedia
Classification: Unclassified
Site requests (Other open bugs)
unspecified
All All
: Low normal (vote)
: ---
Assigned To: Nobody - You can work on this!
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-04-07 14:50 UTC by Tim Weyer
Modified: 2013-04-04 21:28 UTC (History)
4 users (show)

See Also:
Web browser: ---
Mobile Platform: ---
Assignee Huggle Beta Tester: ---


Attachments

Description Tim Weyer 2012-04-07 14:50:34 UTC
On MediaWiki.org, we are using two states of review (sighted and accurate). I see no reason why work with both states. To mark a page as accurate (or to mark a page as sighted which last revision has been marked as accurate) one needs to be a reviewer or coder. Editor membership just allows marking as sighted. On the English and German Wikipedia, there's just 'sighted', no 'accurate'. Please remove accurate or set 'validate' permission for editors, too.
Comment 1 Tim Weyer 2012-04-13 14:04:13 UTC
Supplement: I think the right way would be removing editor group and replacing it by reviewer group (or vice versa), removing 'validate' permission from reviewer (or just don't add it to editor) and set $wgFlaggedRevTags['accuracy']['levels'] = 1; I've written a script to replace a given usergroup by another one. It can be found at https://www.mediawiki.org/wiki/User:SVG/Maintenance_scripts/removeRedundantUserGroup.php

Here's my suggestion for the new configuration of flaggedrevs.php:

Remove: $wgGroupPermissions['coder']['validate'] = true;

Add: unset( $wgGroupPermissions['editor'] );

Add: $wgGroupPermissions['reviewer']['validate'] = false;
     OR
     unset( $wgGroupPermissions['reviewer']['validate'] );

Add:
$wgAddGroups['sysop'] = array_diff( $wgAddGroups['sysop'], array( 'editor' ) );
$wgRemoveGroups['sysop'] = array_diff( $wgRemoveGroups['sysop'], array( 'editor' ) );

Add:
$wgAddGroups['sysop'][] = 'reviewer';
$wgRemoveGroups['sysop'][] = 'reviewer';

Add: unset( $wgGroupPermissions['autoreview'] ); // is an unused group and can't be granted

Add: $wgFlaggedRevTags['accuracy']['levels'] = 1;
Comment 2 Tim Weyer 2012-04-13 15:12:15 UTC
Erm... my script is just to remove groups, haha, forgot it. But it can be used to remove editor group from users who are also reviewers. I'll write a new script if needed.
Comment 3 Nemo 2013-04-04 21:22:03 UTC
(In reply to comment #0)
> On MediaWiki.org, we are using two states of review (sighted and accurate). I
> see no reason why work with both states. 

There are reasons, see e.g. <https://www.mediawiki.org/wiki/Thread:Project:Current_issues/Replace_full_protection_with_FlaggedRevs>
Closing until there is demonstrated consensus.
Comment 4 Chad H. 2013-04-04 21:24:40 UTC
I agree that we should remove the two states.

In fact, I'd even go so far as to wonder if FlaggedRevs hasn't turned out on mw.org the way I'd hoped when I asked Brion to enable...and it's time to visit turning it off.
Comment 5 Nemo 2013-04-04 21:28:24 UTC
(In reply to comment #4)
> In fact, I'd even go so far as to wonder if FlaggedRevs hasn't turned out on
> mw.org the way I'd hoped when I asked Brion to enable...and it's time to
> visit
> turning it off.

"Accurate" is indeed used quite rarely and sometimes even by mistake, but a discussion on wiki seems needed anyway. Not to find "consensus" of course, devs do whatever they want with mediawiki.org ;), but to figure out the needed steps without cluttering bugzilla.

Note You need to log in before you can comment on or make changes to this bug.


Navigation
Links